[GitHub] [calcite] zoudan commented on a diff in pull request #3141: [CALCITE-5624] Add support to parse array function call with Spark

["zoudan (via GitHub)" <gi...@apache.org>]

zoudan commented on code in PR #3141:
URL: https://github.com/apache/calcite/pull/3141#discussion_r1157124053


##########
core/src/main/java/org/apache/calcite/sql/validate/SqlConformance.java:
##########
@@ -576,4 +576,26 @@ public interface SqlConformance {
    */
   @Experimental
   boolean allowCoercionStringToArray();
+

Review Comment:
   remove a redundant empty line



##########
core/src/main/java/org/apache/calcite/sql/validate/SqlConformanceEnum.java:
##########
@@ -439,4 +446,13 @@ public enum SqlConformanceEnum implements SqlConformance {
       return false;
     }
   }
+
+  @Override public boolean allowArrayFunction() {
+    switch (this) {

Review Comment:
   `return this == SPARK`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org