You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/01 15:37:15 UTC
[GitHub] [flink] suxinglee opened a new pull request, #20134: [FLINK-28353][k8s] Exclude unschedulable nodes using IP addresses of …
suxinglee opened a new pull request, #20134:
URL: https://github.com/apache/flink/pull/20134
## What is the purpose of the change
when the job is submitted to the k8s cluster and the parameter `-Dkubernetes.rest-service.exposed.type=NodePort` is used, the web ui address of the job obtained at this time is the IP of any machine in the k8s cluster.
but client will throw connect refuse exception when the node's schedule status is unschedulable. We should exclude those node IPs to choose web ui address
## Brief change log
*(for example:)*
- `ServiceType#getRestEndpoint` search node exclude unschedulable node (spec.unschedulable = true)
## Verifying this change
update unit tests for the change. `Fabric8FlinkKubeClientTest#testNodePortServiceWithInternalIP`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] suxinglee commented on pull request #20134: [FLINK-28353][k8s] Exclude unschedulable nodes using IP addresses of kubernetes nodes
Posted by GitBox <gi...@apache.org>.
suxinglee commented on PR #20134:
URL: https://github.com/apache/flink/pull/20134#issuecomment-1177198751
Please help to take a review when you are free @wangyang0918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 merged pull request #20134: [FLINK-28353][k8s] Exclude unschedulable nodes using IP addresses of kubernetes nodes
Posted by GitBox <gi...@apache.org>.
wangyang0918 merged PR #20134:
URL: https://github.com/apache/flink/pull/20134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #20134: [FLINK-28353][k8s] Exclude unschedulable nodes using IP addresses of kubernetes nodes
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on PR #20134:
URL: https://github.com/apache/flink/pull/20134#issuecomment-1193967824
Rebase the latest master and force pushed. I will merge this PR once the azure gives the pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20134: [FLINK-28353][k8s] Exclude unschedulable nodes using IP addresses of …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20134:
URL: https://github.com/apache/flink/pull/20134#issuecomment-1172476891
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b8b8d432a712655f92cc37ce639517a414523434",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b8b8d432a712655f92cc37ce639517a414523434",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b8b8d432a712655f92cc37ce639517a414523434 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] suxinglee commented on pull request #20134: [FLINK-28353][k8s] Exclude unschedulable nodes using IP addresses of kubernetes nodes
Posted by GitBox <gi...@apache.org>.
suxinglee commented on PR #20134:
URL: https://github.com/apache/flink/pull/20134#issuecomment-1173279678
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] suxinglee commented on pull request #20134: [FLINK-28353][k8s] Exclude unschedulable nodes using IP addresses of kubernetes nodes
Posted by GitBox <gi...@apache.org>.
suxinglee commented on PR #20134:
URL: https://github.com/apache/flink/pull/20134#issuecomment-1172491801
@dmvk PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org