[GitHub] [pulsar] Nicklee007 commented on a diff in pull request #16325: [fix][broker] fix the local police IsolationGroups cover the defaultIsolationGroups when init managedLedger bookkeeper client

[GitBox <gi...@apache.org>]

Nicklee007 commented on code in PR #16325:
URL: https://github.com/apache/pulsar/pull/16325#discussion_r934118873


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/BookKeeperClientFactoryImpl.java:
##########
@@ -71,9 +71,7 @@ public BookKeeper create(ServiceConfiguration conf, MetadataStoreExtended store,
         MetadataDrivers.registerClientDriver("metadata-store", PulsarMetadataClientDriver.class);
 
         ClientConfiguration bkConf = createBkClientConfiguration(store, conf);
-        if (properties != null) {
-            properties.forEach((key, value) -> bkConf.setProperty(key, value));
-        }
+

Review Comment:
   @Jason918 This change satisfied our expect, the properties only contain bookie isolation properties. So remove the properties do not effect other properties be setting.
   
   https://github.com/apache/pulsar/blob/cb305823b77ae36b67db575793a2f40f874a977a/pulsar-broker/src/main/java/org/apache/pulsar/broker/ManagedLedgerClientFactory.java#L92-L98



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org