[jira] [Commented] (QPID-6979) AttributeValueConverter's Certificate handling code assumes unix line endings

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094037#comment-15094037 ] 

ASF subversion and git services commented on QPID-6979:
-------------------------------------------------------

Commit 1724257 from [~godfrer] in branch 'java/trunk'
[ https://svn.apache.org/r1724257 ]

QPID-6979 : Improve parsing of X509 certificate values

> AttributeValueConverter's Certificate handling code assumes unix line endings
> -----------------------------------------------------------------------------
>
>                 Key: QPID-6979
>                 URL: https://issues.apache.org/jira/browse/QPID-6979
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>            Reporter: Keith Wall
>            Priority: Minor
>             Fix For: qpid-java-6.0.1, qpid-java-6.1
>
>
> The generic code {{AttributeValueConverter}} is used to instantiate model attributes/model operation parameters of type Certificate.   It has the ability to convert from a PEM format representation to a Certificate, but this has a defect.
> It assumes that unix line endings will be used.  If windows line endings were used, the subsequent call to the certificate factory will fail.
> The following model operation is affected by this problem:
> ManagedPeerCertificateTrustStore#addCertificate()
> The workaround is to convert the input to unix line endings.
> The BEGIN/END certificate parsing code should also be enhanced to fail early if it encounters a BEGIN without a corresponding END.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org