[GitHub] [doris] Gabriel39 commented on a diff in pull request #10278: [Improvement] remove olap filters when use in key ranges

[GitBox <gi...@apache.org>]

Gabriel39 commented on code in PR #10278:
URL: https://github.com/apache/doris/pull/10278#discussion_r902322682


##########
be/src/exec/olap_common.h:
##########
@@ -258,6 +258,9 @@ class OlapScanKeys {
     template <class T>
     Status extend_scan_key(ColumnValueRange<T>& range, int32_t max_scan_key_num);
 
+    template <class T>
+    Status extend_scan_key(ColumnValueRange<T>& range, int32_t max_scan_key_num, bool* exact_value);
+

Review Comment:
   To be honest, I considered this way before. Finally I made this because I don't want to mix logics with row-based engine anymore. However, I'm not sure if it's necessary for now and let us wait for more opnions from others :)



##########
be/src/exec/olap_common.h:
##########
@@ -856,4 +859,125 @@ Status OlapScanKeys::extend_scan_key(ColumnValueRange<T>& range, int32_t max_sca
     return Status::OK();
 }
 
+template <class T>
+Status OlapScanKeys::extend_scan_key(ColumnValueRange<T>& range, int32_t max_scan_key_num,
+                                     bool* exact_value) {
+    using namespace std;
+    typedef typename set<T>::const_iterator const_iterator_type;

Review Comment:
   Update. Thanks for your advise!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org