You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "boekkooi-lengoo (via GitHub)" <gi...@apache.org> on 2023/03/14 14:43:56 UTC
[GitHub] [apisix] boekkooi-lengoo opened a new pull request, #9065: Use mtime instead of ctime
boekkooi-lengoo opened a new pull request, #9065:
URL: https://github.com/apache/apisix/pull/9065
### Description
In order to avoid unnecessary reloading of the yaml configuration. The time used to detect the last change to the config file is changed from `change` which is the time of the last file status change to the `modification` time wich is the time of the last data modification.
For more information also checkout http://lunarmodules.github.io/luafilesystem/manual.html#reference and https://linux.die.net/man/2/stat
Fixes: https://github.com/apache/apisix/issues/9051
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] boekkooi-lengoo commented on pull request #9065: fix: unnecessary YAML Config reloads
Posted by "boekkooi-lengoo (via GitHub)" <gi...@apache.org>.
boekkooi-lengoo commented on PR #9065:
URL: https://github.com/apache/apisix/pull/9065#issuecomment-1478167841
Hey @monkeyDluffy6017,
What type of test case should I add?
I'm not sure how to best reproduce the issue in a test using lua.
On a related not after reading https://apenwarr.ca/log/20181113 I'm thinking that we should add `inode` and `size` to the version as well. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: unnecessary YAML Config reloads [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on PR #9065:
URL: https://github.com/apache/apisix/pull/9065#issuecomment-1871016129
ping @boekkooi-lengoo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: unnecessary YAML Config reloads [apisix]
Posted by "boekkooi-lengoo (via GitHub)" <gi...@apache.org>.
boekkooi-lengoo commented on PR #9065:
URL: https://github.com/apache/apisix/pull/9065#issuecomment-1886649339
@monkeyDluffy6017 Created merge commit https://github.com/apache/apisix/pull/9065/commits/684c78d829d9acfa0a3df275e20db9d00d0f25f8 as requested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: unnecessary YAML Config reloads [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9065:
URL: https://github.com/apache/apisix/pull/9065#issuecomment-1886389726
please merge the master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9065: fix: unnecessary YAML Config reloads
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9065:
URL: https://github.com/apache/apisix/pull/9065#issuecomment-1488272428
hi @boekkooi-lengoo, try to follow the following test cases:
https://github.com/apache/apisix/blob/master/t/cli/test_standalone.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: unnecessary YAML Config reloads [apisix]
Posted by "boekkooi-lengoo (via GitHub)" <gi...@apache.org>.
boekkooi-lengoo commented on PR #9065:
URL: https://github.com/apache/apisix/pull/9065#issuecomment-1884946668
@shreemaan-abhishek :ping_pong:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9065: fix: unnecessary YAML Config reloads
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9065:
URL: https://github.com/apache/apisix/pull/9065#issuecomment-1468258742
Test cases is needed, you could follow this: https://github.com/apache/apisix/blob/master/t/config-center-yaml/plugin.t
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: unnecessary YAML Config reloads [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 merged PR #9065:
URL: https://github.com/apache/apisix/pull/9065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org