You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/06 00:49:24 UTC
[GitHub] [hudi] garyli1019 opened a new pull request #1707: [WIP][MINOR] try to fix CI OOM
garyli1019 opened a new pull request #1707:
URL: https://github.com/apache/hudi/pull/1707
## What is the purpose of the pull request
Fix CI OOM issue.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-640766975
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar edited a comment on pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
vinothchandar edited a comment on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-640542414
>The unit test structure need to be refactored. Right now we initialized and clean up resources for every single test, which is inefficient.
@xushiyan @yanghua WDYT? This part is true.. I was also looking into whether we can use a single spark context for the entire test run.. Nonetheless.. Would love some helping hand with the test situation currently.. We need to get CI back stable again, so we can merge with confidence..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar merged pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
bvaradar merged pull request #1707:
URL: https://github.com/apache/hudi/pull/1707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter edited a comment on pull request #1707: [WIP][MINOR] try to fix CI OOM
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-639967452
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=h1) Report
> Merging [#1707](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/fb283934a33a0bc7b11f80e4149f7922fa4f0af5&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1707 +/- ##
============================================
- Coverage 18.19% 18.18% -0.01%
Complexity 857 857
============================================
Files 348 348
Lines 15358 15361 +3
Branches 1525 1525
============================================
Hits 2794 2794
- Misses 12206 12209 +3
Partials 358 358
```
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...i/common/table/view/HoodieTableFileSystemView.java](https://codecov.io/gh/apache/hudi/pull/1707/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvSG9vZGllVGFibGVGaWxlU3lzdGVtVmlldy5qYXZh) | `36.06% <0.00%> (-1.87%)` | `9.00 <0.00> (ø)` | |
| [...e/hudi/timeline/service/FileSystemViewHandler.java](https://codecov.io/gh/apache/hudi/pull/1707/diff?src=pr&el=tree#diff-aHVkaS10aW1lbGluZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RpbWVsaW5lL3NlcnZpY2UvRmlsZVN5c3RlbVZpZXdIYW5kbGVyLmphdmE=) | `39.90% <0.00%> (ø)` | `11.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=footer). Last update [fb28393...54ee824](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] garyli1019 commented on pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
garyli1019 commented on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-640738265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter edited a comment on pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-639967452
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=h1) Report
> Merging [#1707](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/fb283934a33a0bc7b11f80e4149f7922fa4f0af5&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1707 +/- ##
============================================
- Coverage 18.19% 18.18% -0.01%
Complexity 857 857
============================================
Files 348 348
Lines 15358 15361 +3
Branches 1525 1525
============================================
Hits 2794 2794
- Misses 12206 12209 +3
Partials 358 358
```
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...i/common/table/view/HoodieTableFileSystemView.java](https://codecov.io/gh/apache/hudi/pull/1707/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvSG9vZGllVGFibGVGaWxlU3lzdGVtVmlldy5qYXZh) | `36.06% <0.00%> (-1.87%)` | `9.00 <0.00> (ø)` | |
| [...e/hudi/timeline/service/FileSystemViewHandler.java](https://codecov.io/gh/apache/hudi/pull/1707/diff?src=pr&el=tree#diff-aHVkaS10aW1lbGluZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RpbWVsaW5lL3NlcnZpY2UvRmlsZVN5c3RlbVZpZXdIYW5kbGVyLmphdmE=) | `39.90% <0.00%> (ø)` | `11.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=footer). Last update [fb28393...54ee824](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-640572401
> > The unit test structure need to be refactored. Right now we initialized and clean up resources for every single test, which is inefficient.
>
> @xushiyan @yanghua WDYT? This part is true.. I was also looking into whether we can use a single spark context for the entire test run.. Nonetheless.. Would love some helping hand with the test situation currently.. We need to get CI back stable again, so we can merge with confidence..
My thought: Can we distinguish the objects of `HoodieClientTestHarness` into **weight** and **light** level? For example, `JavaSparkContext` and `MiniDFSCluster` can be considered as the weight objects. Then we can initialize them via `ClassRule` or `Rule` mode? WDYT? @xushiyan and other guys.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on a change in pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
bvaradar commented on a change in pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#discussion_r436456552
##########
File path: hudi-client/src/test/java/org/apache/hudi/client/TestMultiFS.java
##########
@@ -63,9 +63,7 @@ public void setUp() throws Exception {
@AfterEach
public void tearDown() throws Exception {
- cleanupSparkContexts();
- cleanupDFS();
- cleanupTestDataGenerator();
+ cleanupResources();
Review comment:
@garyli1019 : Is this one of the places where we are missing the cleanup of resources ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] garyli1019 commented on a change in pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
garyli1019 commented on a change in pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#discussion_r436467598
##########
File path: hudi-client/src/test/java/org/apache/hudi/client/TestMultiFS.java
##########
@@ -63,9 +63,7 @@ public void setUp() throws Exception {
@AfterEach
public void tearDown() throws Exception {
- cleanupSparkContexts();
- cleanupDFS();
- cleanupTestDataGenerator();
+ cleanupResources();
Review comment:
We didn't miss one yet but it's easy to miss, so I put all the clean up in one place.
The leak I found was `HoodieLogFileReader` and `HoodieWrapperFileSystem`. These instances were created from different classes and difficult to clean up.
By setting `Xmx2g` is consuming less memory than `Xmx4g`, probably because of the more aggressive GC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter commented on pull request #1707: [WIP][MINOR] try to fix CI OOM
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-639967452
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=h1) Report
> Merging [#1707](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/fb283934a33a0bc7b11f80e4149f7922fa4f0af5&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1707 +/- ##
=========================================
Coverage 18.19% 18.19%
Complexity 857 857
=========================================
Files 348 348
Lines 15358 15358
Branches 1525 1525
=========================================
Hits 2794 2794
Misses 12206 12206
Partials 358 358
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=footer). Last update [fb28393...1f86240](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on a change in pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
bvaradar commented on a change in pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#discussion_r436475281
##########
File path: hudi-client/src/test/java/org/apache/hudi/client/TestMultiFS.java
##########
@@ -63,9 +63,7 @@ public void setUp() throws Exception {
@AfterEach
public void tearDown() throws Exception {
- cleanupSparkContexts();
- cleanupDFS();
- cleanupTestDataGenerator();
+ cleanupResources();
Review comment:
@garyli1019 : Can you open a jira with information about the leak that you found in HoodieLogFileReader and HoodieWrapperFileSystem. We need to get to the top of this asap.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] garyli1019 commented on pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
garyli1019 commented on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-640307790
@bvaradar @vinothchandar This PR fixes more tests on top of HUDI-988, but not completely fix the memory leak. Two consecutive builds were passed.
The unit test structure need to be refactored. Right now we initialized and clean up resources for every single test, which is inefficient.
Too many logs will lead to CI failure as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter edited a comment on pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-639967452
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=h1) Report
> Merging [#1707](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/fb283934a33a0bc7b11f80e4149f7922fa4f0af5&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1707 +/- ##
=========================================
Coverage 18.19% 18.20%
- Complexity 857 858 +1
=========================================
Files 348 348
Lines 15358 15361 +3
Branches 1525 1525
=========================================
+ Hits 2794 2796 +2
- Misses 12206 12207 +1
Partials 358 358
```
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...i/common/table/view/HoodieTableFileSystemView.java](https://codecov.io/gh/apache/hudi/pull/1707/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvSG9vZGllVGFibGVGaWxlU3lzdGVtVmlldy5qYXZh) | `36.06% <0.00%> (-1.87%)` | `9.00 <0.00> (ø)` | |
| [...e/hudi/timeline/service/FileSystemViewHandler.java](https://codecov.io/gh/apache/hudi/pull/1707/diff?src=pr&el=tree#diff-aHVkaS10aW1lbGluZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RpbWVsaW5lL3NlcnZpY2UvRmlsZVN5c3RlbVZpZXdIYW5kbGVyLmphdmE=) | `39.90% <0.00%> (ø)` | `11.00 <0.00> (ø)` | |
| [...apache/hudi/common/fs/HoodieWrapperFileSystem.java](https://codecov.io/gh/apache/hudi/pull/1707/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL2ZzL0hvb2RpZVdyYXBwZXJGaWxlU3lzdGVtLmphdmE=) | `22.69% <0.00%> (+0.70%)` | `29.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=footer). Last update [fb28393...54ee824](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-640542414
>The unit test structure need to be refactored. Right now we initialized and clean up resources for every single test, which is inefficient.
@xushiyan @yanghua This part is true.. I was also looking into whether we can use a single spark context for the entire test run.. Nonetheless.. Would love some helping hand with the test situation currently.. We need to get CI back stable again, so we can merge with confidence..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
bvaradar commented on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-640391981
Will merge this change and re-trigger other PRs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter edited a comment on pull request #1707: [WIP][MINOR] try to fix CI OOM
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-639967452
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=h1) Report
> Merging [#1707](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/fb283934a33a0bc7b11f80e4149f7922fa4f0af5&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1707 +/- ##
=========================================
Coverage 18.19% 18.19%
Complexity 857 857
=========================================
Files 348 348
Lines 15358 15358
Branches 1525 1525
=========================================
Hits 2794 2794
Misses 12206 12206
Partials 358 358
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=footer). Last update [fb28393...1f86240](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter edited a comment on pull request #1707: [WIP][MINOR] try to fix CI OOM
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-639967452
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=h1) Report
> Merging [#1707](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hudi/commit/fb283934a33a0bc7b11f80e4149f7922fa4f0af5&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1707 +/- ##
============================================
- Coverage 18.19% 18.18% -0.01%
Complexity 857 857
============================================
Files 348 348
Lines 15358 15361 +3
Branches 1525 1525
============================================
Hits 2794 2794
- Misses 12206 12209 +3
Partials 358 358
```
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...i/common/table/view/HoodieTableFileSystemView.java](https://codecov.io/gh/apache/hudi/pull/1707/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvSG9vZGllVGFibGVGaWxlU3lzdGVtVmlldy5qYXZh) | `36.06% <0.00%> (-1.87%)` | `9.00 <0.00> (ø)` | |
| [...e/hudi/timeline/service/FileSystemViewHandler.java](https://codecov.io/gh/apache/hudi/pull/1707/diff?src=pr&el=tree#diff-aHVkaS10aW1lbGluZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RpbWVsaW5lL3NlcnZpY2UvRmlsZVN5c3RlbVZpZXdIYW5kbGVyLmphdmE=) | `39.90% <0.00%> (ø)` | `11.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=footer). Last update [fb28393...1d19d6d](https://codecov.io/gh/apache/hudi/pull/1707?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bvaradar commented on pull request #1707: [HUDI-988] fix more unit tests flakiness
Posted by GitBox <gi...@apache.org>.
bvaradar commented on pull request #1707:
URL: https://github.com/apache/hudi/pull/1707#issuecomment-640360777
@garyli1019 : Will review the code and also rerun few more times before merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org