You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2022/01/16 06:19:59 UTC

Review Request 73804: RANGER-3586: updated script evaluator to support csv of group/tag attributes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73804/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3586
    https://issues.apache.org/jira/browse/RANGER-3586


Repository: ranger


Description
-------

- added methods to ctx to return comma-separated-value of group/tag attributes, both quoted and unquoted values


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java 6f12b1b5a 
  agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java ff638b2b1 


Diff: https://reviews.apache.org/r/73804/diff/1/


Testing
-------

- added unit tests to cover new expressions
- verified that all existing unit tests pass successfully


Thanks,

Madhan Neethiraj


Re: Review Request 73804: RANGER-3586: updated script evaluator to support csv of group/tag attributes

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73804/#review223967
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On Jan. 16, 2022, 6:19 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73804/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2022, 6:19 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3586
>     https://issues.apache.org/jira/browse/RANGER-3586
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> - added methods to ctx to return comma-separated-value of group/tag attributes, both quoted and unquoted values
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java 6f12b1b5a 
>   agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java ff638b2b1 
> 
> 
> Diff: https://reviews.apache.org/r/73804/diff/1/
> 
> 
> Testing
> -------
> 
> - added unit tests to cover new expressions
> - verified that all existing unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>