You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Lukasz Lenart <lu...@apache.org> on 2021/10/19 08:18:21 UTC
[TEST] Struts 2.5.27 test build is ready
Hi,
Please take a time and test the bits - any help is appreciated. Please
report any problems. I'll call for a vote in a few days if no problems
will be spotted.
Staging Maven repo
https://repository.apache.org/content/groups/staging/
Standalone artifacts
https://dist.apache.org/repos/dist/dev/struts/2.5.27/
Release notes
https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.27
Kind regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: Re: [TEST] Struts 2.5.27 test build is ready
Posted by James Chaplin <jc...@apache.org>.
Hi Lukasz and Greg.
Thanks for looking into the behaviour, Lukasz.
And thanks, Greg, for indicating you did not see any similar warnings when running your application on Tomcat with 2.5.27.
I noticed those log warn outputs when running the 2.5.27 Showcase on Tomcat 8.5.x, so if there is some sort of race condition involved, it may not be just when running under Jetty. Or, it could be something specific to the Showcase itself.
Unless the unexpected log warnings can be confirmed/reproduced as a general issue for 2.5.27 in real-world usage, I guess it should be OK.
Thanks again for taking a look.
Regards,
James.
On 2021/10/31 14:30:40 Lukasz Lenart wrote:
> niedz., 31 paź 2021 o 12:41 Greg Huber <gr...@gmail.com> napisał(a):
> >
> > Not seen anything re this in the tomcat logs, and have been running
> > 2.5.27 for a week or so.
> >
> > The vote would be +1 for me.
>
> Great, thanks a lot!
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.27 test build is ready
Posted by Yasser Zamani <ya...@apache.org>.
Hi James,
Unfortunately couldn't find a chance to look into, maybe I'm wrong but
as far as I remember, there are pages in the showcase app that are
opening directly without an action in behind which is the source of
those warnings in the new Struts 2.5.27 I think.
Thanks for looking into it!
Regards.
On 11/6/2021 5:51 AM, James Chaplin wrote:
> Hi Lukasz and Greg.
>
> Thanks for looking into the behaviour, Lukasz.
>
> And thanks, Greg, for indicating you did not see any similar warnings when running your application on Tomcat with 2.5.27.
>
> I noticed those log warn outputs when running the 2.5.27 Showcase on Tomcat 8.5.x, so if there is some sort of race condition involved, it may not be just when running under Jetty. Or, it could be something specific to the Showcase itself.
>
> Unless the unexpected log warnings can be confirmed/reproduced as a general issue for 2.5.27 in real-world usage, I guess it should be OK.
>
> Thanks again for taking a look.
>
> Regards,
>
> James.
>
> On 2021/10/31 14:30:40 Lukasz Lenart wrote:
>> niedz., 31 paź 2021 o 12:41 Greg Huber <gr...@gmail.com> napisał(a):
>>>
>>> Not seen anything re this in the tomcat logs, and have been running
>>> 2.5.27 for a week or so.
>>>
>>> The vote would be +1 for me.
>>
>> Great, thanks a lot!
>>
>>
>> Regards
>> --
>> Łukasz
>> + 48 606 323 122 http://www.lenart.org.pl/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.27 test build is ready
Posted by Lukasz Lenart <lu...@apache.org>.
niedz., 31 paź 2021 o 12:41 Greg Huber <gr...@gmail.com> napisał(a):
>
> Not seen anything re this in the tomcat logs, and have been running
> 2.5.27 for a week or so.
>
> The vote would be +1 for me.
Great, thanks a lot!
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.27 test build is ready
Posted by Greg Huber <gr...@gmail.com>.
Not seen anything re this in the tomcat logs, and have been running
2.5.27 for a week or so.
The vote would be +1 for me.
On 31/10/2021 11:33, Lukasz Lenart wrote:
> After digging into this issue I have no idea what can be wrong. It
> happens very rare, after adding some logging around, it never happened
> again:
>
> Object action = (ai == null) ? null : ai.getAction();
> if (action == null) {
> LOG.debug("ActionContext: {}", ActionContext.getContext());
> LOG.warn("Rendering tag {} out of Action scope, accessing directly
> JSPs is not recommended! " +
> "Please read
> https://struts.apache.org/security/#never-expose-jsp-files-directly",
> templateName);
> } else {
> LOG.debug("Action is defined: {}", action);
> }
>
> Looks like a race condition in Jetty which happens from time to time.
>
> @Greg Huber did you notice any of such problems?
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> czw., 28 paź 2021 o 09:03 Lukasz Lenart <lu...@apache.org> napisał(a):
>> Thanks James,
>>
>> Good catch, I was able to identify the problem and I will prepare a fix soon.
>>
>> Regards
>> Łukasz
>>
>> śr., 27 paź 2021 o 02:59 James Chaplin <jc...@apache.org> napisał(a):
>>> Hi Lukasz.
>>>
>>> Using the 2.5.27 test build zip artifacts, I tried out the Showcase application. I did not notice any issues with the 2.5.27 Showcase interactively, as things seemed to work OK (similar to previous releases).
>>>
>>> However, looking at the console logs when running it, there were a bunch of warn-level outputs mentioning the anchor (a.ftl and a-close.ftl), for the first access of certain features in the Showcase:
>>>
>>> "template.FreemarkerTemplateEngine (FreemarkerTemplateEngine.java:125) - Rendering tag /template/simple/a.ftl out of Action scope, accessing directly JSPs is not recommended! Please read https://struts.apache.org/security/#never-expose-jsp-files-directly"
>>> "template.FreemarkerTemplateEngine (FreemarkerTemplateEngine.java:125) - Rendering tag /template/simple/a-close.ftl out of Action scope, accessing directly JSPs is not recommended! Please read https://struts.apache.org/security/#never-expose-jsp-files-directly"
>>>
>>> I noticed those for the initial main page load of the Showcase, as well as the Person Manager and CRUD examples. It seemed to only occur the 1st time they were accessed within a given browser session.
>>>
>>> It is entirely possible that those are valid warnings (showing up via the change in FreemarkerTemplateEngine in 2.5.27), due to the structure of the Showcase and some of its examples, but I could not confirm that. I wanted to advise of what I saw, in case there might be a weird corner-case for "s:a" anchor tag processing that could produce unexpected warnings with 2.5.27.
>>>
>>> If anyone has tried testing out an application with 2.5.27 which uses "s:a" tags, please let the dev list know if you see similar log warnings (and are not expecting to).
>>>
>>> Regards,
>>>
>>> James.
>>>
>>>
>>> On 2021/10/26 12:48:29, Lukasz Lenart <lu...@apache.org> wrote:
>>>> I assume there is no objection to starting the Vote.
>>>>
>>>> wt., 19 paź 2021 o 12:26 Greg Huber <gr...@gmail.com> napisał(a):
>>>>> They seem to download when I use maven-dependency-plugin.
>>>>>
>>>>> [INFO]
>>>>> [INFO] --- maven-dependency-plugin:3.2.0:copy-dependencies
>>>>> (copy-dependencies) @ events ---
>>>>> [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
>>>>> for https://repo.maven.apache.org/maven2
>>>>> [INFO] Downloading from :
>>>>> https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
>>>>> [INFO] Downloaded from :
>>>>> https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
>>>>> (4.3 kB at 53 kB/s)
>>>>> [DEBUG] Writing tracking file
>>>>> /home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/_remote.repositories
>>>>> [DEBUG] Writing tracking file
>>>>> /home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom.lastUpdated
>>>>> [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
>>>>> for https://repo.maven.apache.org/maven2
>>>>> [INFO] Downloading from :
>>>>> https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
>>>>> [INFO] Downloaded from :
>>>>> https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
>>>>> (9.8 kB at 656 kB/s)
>>>>> [DEBUG] Writing tracking file
>>>>> /home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/_remote.repositories
>>>>> [DEBUG] Writing tracking file
>>>>> /home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom.lastUpdated
>>>>> [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
>>>>> for https://repo.maven.apache.org/maven2
>>>>> [INFO] Downloading from :
>>>>> https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
>>>>> [INFO] Downloaded from :
>>>>> https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
>>>>> (12 kB at 845 kB/s)
>>>>> [DEBUG] Writing tracking file
>>>>> /home/me/.m2/repository/org/apache/struts/struts-master/4/_remote.repositories
>>>>> [DEBUG] Writing tracking file
>>>>> /home/me/.m2/repository/org/apache/struts/struts-master/4/struts-master-4.pom.lastUpdated
>>>>> [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
>>>>> for https://repo.maven.apache.org/maven2
>>>>> [INFO] Downloading from :
>>>>> https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
>>>>> [INFO] Downloaded from :
>>>>> https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
>>>>> (3.1 kB at 220 kB/s)
>>>>> [DEBUG] Writing tracking file
>>>>> /home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/_remote.repositories
>>>>> [DEBUG] Writing tracking file
>>>>> /home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom.lastUpdated
>>>>> [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
>>>>> for https://repo.maven.apache.org/maven2
>>>>> [INFO] Downloading from :
>>>>> https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
>>>>> [INFO] Downloaded from :
>>>>> https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
>>>>> (2.9 kB at 208 kB/s)
>>>>> [DEBUG] Writing tracking file
>>>>> /home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/_remote.repositories
>>>>> [DEBUG] Writing tracking file
>>>>> /home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom.lastUpdated
>>>>> [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=427359,
>>>>> ConflictMarker.markTime=174089, ConflictMarker.nodeCount=435,
>>>>> ConflictIdSorter.graphTime=123092, ConflictIdSorter.topsortTime=76635,
>>>>> ConflictIdSorter.conflictIdCount=93,
>>>>> ConflictIdSorter.conflictIdCycleCount=0,
>>>>> ConflictResolver.totalTime=1514331,
>>>>> ConflictResolver.conflictItemCount=194,
>>>>> DefaultDependencyCollector.collectTime=267604268,
>>>>> DefaultDependencyCollector.transformTime=2378444}
>>>>>
>>>>>
>>>>> I have scanned the .m2 struts folder, and their is nothing in the
>>>>> struts2 poms using struts1
>>>>>
>>>>>
>>>>> On 19/10/2021 10:29, Lukasz Lenart wrote:
>>>>>> wt., 19 paź 2021 o 11:20 Greg Huber <gr...@gmail.com> napisał(a):
>>>>>>> Also why in my ~.m2/repository/org/apache/struts folder I have struts 1
>>>>>>> stuff? If I remove my repo above it still downloads them.
>>>>>>>
>>>>>>> struts-core, struts-master, struts-parent etc
>>>>>>>
>>>>>>> Maybe a maven thing?
>>>>>> Some plugins can have transient dependencies on the Apache Struts 1,
>>>>>> use `mvn dependency:tree` to track them down. It could also be
>>>>>> Freemarker, Tiles or Spring.
>>>>>>
>>>>>>
>>>>>> Regards
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>>> For additional commands, e-mail: dev-help@struts.apache.org
>>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.27 test build is ready
Posted by Lukasz Lenart <lu...@apache.org>.
After digging into this issue I have no idea what can be wrong. It
happens very rare, after adding some logging around, it never happened
again:
Object action = (ai == null) ? null : ai.getAction();
if (action == null) {
LOG.debug("ActionContext: {}", ActionContext.getContext());
LOG.warn("Rendering tag {} out of Action scope, accessing directly
JSPs is not recommended! " +
"Please read
https://struts.apache.org/security/#never-expose-jsp-files-directly",
templateName);
} else {
LOG.debug("Action is defined: {}", action);
}
Looks like a race condition in Jetty which happens from time to time.
@Greg Huber did you notice any of such problems?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
czw., 28 paź 2021 o 09:03 Lukasz Lenart <lu...@apache.org> napisał(a):
>
> Thanks James,
>
> Good catch, I was able to identify the problem and I will prepare a fix soon.
>
> Regards
> Łukasz
>
> śr., 27 paź 2021 o 02:59 James Chaplin <jc...@apache.org> napisał(a):
> >
> > Hi Lukasz.
> >
> > Using the 2.5.27 test build zip artifacts, I tried out the Showcase application. I did not notice any issues with the 2.5.27 Showcase interactively, as things seemed to work OK (similar to previous releases).
> >
> > However, looking at the console logs when running it, there were a bunch of warn-level outputs mentioning the anchor (a.ftl and a-close.ftl), for the first access of certain features in the Showcase:
> >
> > "template.FreemarkerTemplateEngine (FreemarkerTemplateEngine.java:125) - Rendering tag /template/simple/a.ftl out of Action scope, accessing directly JSPs is not recommended! Please read https://struts.apache.org/security/#never-expose-jsp-files-directly"
> > "template.FreemarkerTemplateEngine (FreemarkerTemplateEngine.java:125) - Rendering tag /template/simple/a-close.ftl out of Action scope, accessing directly JSPs is not recommended! Please read https://struts.apache.org/security/#never-expose-jsp-files-directly"
> >
> > I noticed those for the initial main page load of the Showcase, as well as the Person Manager and CRUD examples. It seemed to only occur the 1st time they were accessed within a given browser session.
> >
> > It is entirely possible that those are valid warnings (showing up via the change in FreemarkerTemplateEngine in 2.5.27), due to the structure of the Showcase and some of its examples, but I could not confirm that. I wanted to advise of what I saw, in case there might be a weird corner-case for "s:a" anchor tag processing that could produce unexpected warnings with 2.5.27.
> >
> > If anyone has tried testing out an application with 2.5.27 which uses "s:a" tags, please let the dev list know if you see similar log warnings (and are not expecting to).
> >
> > Regards,
> >
> > James.
> >
> >
> > On 2021/10/26 12:48:29, Lukasz Lenart <lu...@apache.org> wrote:
> > > I assume there is no objection to starting the Vote.
> > >
> > > wt., 19 paź 2021 o 12:26 Greg Huber <gr...@gmail.com> napisał(a):
> > > >
> > > > They seem to download when I use maven-dependency-plugin.
> > > >
> > > > [INFO]
> > > > [INFO] --- maven-dependency-plugin:3.2.0:copy-dependencies
> > > > (copy-dependencies) @ events ---
> > > > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > > > for https://repo.maven.apache.org/maven2
> > > > [INFO] Downloading from :
> > > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
> > > > [INFO] Downloaded from :
> > > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
> > > > (4.3 kB at 53 kB/s)
> > > > [DEBUG] Writing tracking file
> > > > /home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/_remote.repositories
> > > > [DEBUG] Writing tracking file
> > > > /home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom.lastUpdated
> > > > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > > > for https://repo.maven.apache.org/maven2
> > > > [INFO] Downloading from :
> > > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
> > > > [INFO] Downloaded from :
> > > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
> > > > (9.8 kB at 656 kB/s)
> > > > [DEBUG] Writing tracking file
> > > > /home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/_remote.repositories
> > > > [DEBUG] Writing tracking file
> > > > /home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom.lastUpdated
> > > > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > > > for https://repo.maven.apache.org/maven2
> > > > [INFO] Downloading from :
> > > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
> > > > [INFO] Downloaded from :
> > > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
> > > > (12 kB at 845 kB/s)
> > > > [DEBUG] Writing tracking file
> > > > /home/me/.m2/repository/org/apache/struts/struts-master/4/_remote.repositories
> > > > [DEBUG] Writing tracking file
> > > > /home/me/.m2/repository/org/apache/struts/struts-master/4/struts-master-4.pom.lastUpdated
> > > > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > > > for https://repo.maven.apache.org/maven2
> > > > [INFO] Downloading from :
> > > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
> > > > [INFO] Downloaded from :
> > > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
> > > > (3.1 kB at 220 kB/s)
> > > > [DEBUG] Writing tracking file
> > > > /home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/_remote.repositories
> > > > [DEBUG] Writing tracking file
> > > > /home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom.lastUpdated
> > > > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > > > for https://repo.maven.apache.org/maven2
> > > > [INFO] Downloading from :
> > > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
> > > > [INFO] Downloaded from :
> > > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
> > > > (2.9 kB at 208 kB/s)
> > > > [DEBUG] Writing tracking file
> > > > /home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/_remote.repositories
> > > > [DEBUG] Writing tracking file
> > > > /home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom.lastUpdated
> > > > [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=427359,
> > > > ConflictMarker.markTime=174089, ConflictMarker.nodeCount=435,
> > > > ConflictIdSorter.graphTime=123092, ConflictIdSorter.topsortTime=76635,
> > > > ConflictIdSorter.conflictIdCount=93,
> > > > ConflictIdSorter.conflictIdCycleCount=0,
> > > > ConflictResolver.totalTime=1514331,
> > > > ConflictResolver.conflictItemCount=194,
> > > > DefaultDependencyCollector.collectTime=267604268,
> > > > DefaultDependencyCollector.transformTime=2378444}
> > > >
> > > >
> > > > I have scanned the .m2 struts folder, and their is nothing in the
> > > > struts2 poms using struts1
> > > >
> > > >
> > > > On 19/10/2021 10:29, Lukasz Lenart wrote:
> > > > > wt., 19 paź 2021 o 11:20 Greg Huber <gr...@gmail.com> napisał(a):
> > > > >> Also why in my ~.m2/repository/org/apache/struts folder I have struts 1
> > > > >> stuff? If I remove my repo above it still downloads them.
> > > > >>
> > > > >> struts-core, struts-master, struts-parent etc
> > > > >>
> > > > >> Maybe a maven thing?
> > > > > Some plugins can have transient dependencies on the Apache Struts 1,
> > > > > use `mvn dependency:tree` to track them down. It could also be
> > > > > Freemarker, Tiles or Spring.
> > > > >
> > > > >
> > > > > Regards
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > > > For additional commands, e-mail: dev-help@struts.apache.org
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > > For additional commands, e-mail: dev-help@struts.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.27 test build is ready
Posted by Lukasz Lenart <lu...@apache.org>.
Thanks James,
Good catch, I was able to identify the problem and I will prepare a fix soon.
Regards
Łukasz
śr., 27 paź 2021 o 02:59 James Chaplin <jc...@apache.org> napisał(a):
>
> Hi Lukasz.
>
> Using the 2.5.27 test build zip artifacts, I tried out the Showcase application. I did not notice any issues with the 2.5.27 Showcase interactively, as things seemed to work OK (similar to previous releases).
>
> However, looking at the console logs when running it, there were a bunch of warn-level outputs mentioning the anchor (a.ftl and a-close.ftl), for the first access of certain features in the Showcase:
>
> "template.FreemarkerTemplateEngine (FreemarkerTemplateEngine.java:125) - Rendering tag /template/simple/a.ftl out of Action scope, accessing directly JSPs is not recommended! Please read https://struts.apache.org/security/#never-expose-jsp-files-directly"
> "template.FreemarkerTemplateEngine (FreemarkerTemplateEngine.java:125) - Rendering tag /template/simple/a-close.ftl out of Action scope, accessing directly JSPs is not recommended! Please read https://struts.apache.org/security/#never-expose-jsp-files-directly"
>
> I noticed those for the initial main page load of the Showcase, as well as the Person Manager and CRUD examples. It seemed to only occur the 1st time they were accessed within a given browser session.
>
> It is entirely possible that those are valid warnings (showing up via the change in FreemarkerTemplateEngine in 2.5.27), due to the structure of the Showcase and some of its examples, but I could not confirm that. I wanted to advise of what I saw, in case there might be a weird corner-case for "s:a" anchor tag processing that could produce unexpected warnings with 2.5.27.
>
> If anyone has tried testing out an application with 2.5.27 which uses "s:a" tags, please let the dev list know if you see similar log warnings (and are not expecting to).
>
> Regards,
>
> James.
>
>
> On 2021/10/26 12:48:29, Lukasz Lenart <lu...@apache.org> wrote:
> > I assume there is no objection to starting the Vote.
> >
> > wt., 19 paź 2021 o 12:26 Greg Huber <gr...@gmail.com> napisał(a):
> > >
> > > They seem to download when I use maven-dependency-plugin.
> > >
> > > [INFO]
> > > [INFO] --- maven-dependency-plugin:3.2.0:copy-dependencies
> > > (copy-dependencies) @ events ---
> > > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > > for https://repo.maven.apache.org/maven2
> > > [INFO] Downloading from :
> > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
> > > [INFO] Downloaded from :
> > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
> > > (4.3 kB at 53 kB/s)
> > > [DEBUG] Writing tracking file
> > > /home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/_remote.repositories
> > > [DEBUG] Writing tracking file
> > > /home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom.lastUpdated
> > > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > > for https://repo.maven.apache.org/maven2
> > > [INFO] Downloading from :
> > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
> > > [INFO] Downloaded from :
> > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
> > > (9.8 kB at 656 kB/s)
> > > [DEBUG] Writing tracking file
> > > /home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/_remote.repositories
> > > [DEBUG] Writing tracking file
> > > /home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom.lastUpdated
> > > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > > for https://repo.maven.apache.org/maven2
> > > [INFO] Downloading from :
> > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
> > > [INFO] Downloaded from :
> > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
> > > (12 kB at 845 kB/s)
> > > [DEBUG] Writing tracking file
> > > /home/me/.m2/repository/org/apache/struts/struts-master/4/_remote.repositories
> > > [DEBUG] Writing tracking file
> > > /home/me/.m2/repository/org/apache/struts/struts-master/4/struts-master-4.pom.lastUpdated
> > > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > > for https://repo.maven.apache.org/maven2
> > > [INFO] Downloading from :
> > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
> > > [INFO] Downloaded from :
> > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
> > > (3.1 kB at 220 kB/s)
> > > [DEBUG] Writing tracking file
> > > /home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/_remote.repositories
> > > [DEBUG] Writing tracking file
> > > /home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom.lastUpdated
> > > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > > for https://repo.maven.apache.org/maven2
> > > [INFO] Downloading from :
> > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
> > > [INFO] Downloaded from :
> > > https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
> > > (2.9 kB at 208 kB/s)
> > > [DEBUG] Writing tracking file
> > > /home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/_remote.repositories
> > > [DEBUG] Writing tracking file
> > > /home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom.lastUpdated
> > > [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=427359,
> > > ConflictMarker.markTime=174089, ConflictMarker.nodeCount=435,
> > > ConflictIdSorter.graphTime=123092, ConflictIdSorter.topsortTime=76635,
> > > ConflictIdSorter.conflictIdCount=93,
> > > ConflictIdSorter.conflictIdCycleCount=0,
> > > ConflictResolver.totalTime=1514331,
> > > ConflictResolver.conflictItemCount=194,
> > > DefaultDependencyCollector.collectTime=267604268,
> > > DefaultDependencyCollector.transformTime=2378444}
> > >
> > >
> > > I have scanned the .m2 struts folder, and their is nothing in the
> > > struts2 poms using struts1
> > >
> > >
> > > On 19/10/2021 10:29, Lukasz Lenart wrote:
> > > > wt., 19 paź 2021 o 11:20 Greg Huber <gr...@gmail.com> napisał(a):
> > > >> Also why in my ~.m2/repository/org/apache/struts folder I have struts 1
> > > >> stuff? If I remove my repo above it still downloads them.
> > > >>
> > > >> struts-core, struts-master, struts-parent etc
> > > >>
> > > >> Maybe a maven thing?
> > > > Some plugins can have transient dependencies on the Apache Struts 1,
> > > > use `mvn dependency:tree` to track them down. It could also be
> > > > Freemarker, Tiles or Spring.
> > > >
> > > >
> > > > Regards
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > > For additional commands, e-mail: dev-help@struts.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.27 test build is ready
Posted by James Chaplin <jc...@apache.org>.
Hi Lukasz.
Using the 2.5.27 test build zip artifacts, I tried out the Showcase application. I did not notice any issues with the 2.5.27 Showcase interactively, as things seemed to work OK (similar to previous releases).
However, looking at the console logs when running it, there were a bunch of warn-level outputs mentioning the anchor (a.ftl and a-close.ftl), for the first access of certain features in the Showcase:
"template.FreemarkerTemplateEngine (FreemarkerTemplateEngine.java:125) - Rendering tag /template/simple/a.ftl out of Action scope, accessing directly JSPs is not recommended! Please read https://struts.apache.org/security/#never-expose-jsp-files-directly"
"template.FreemarkerTemplateEngine (FreemarkerTemplateEngine.java:125) - Rendering tag /template/simple/a-close.ftl out of Action scope, accessing directly JSPs is not recommended! Please read https://struts.apache.org/security/#never-expose-jsp-files-directly"
I noticed those for the initial main page load of the Showcase, as well as the Person Manager and CRUD examples. It seemed to only occur the 1st time they were accessed within a given browser session.
It is entirely possible that those are valid warnings (showing up via the change in FreemarkerTemplateEngine in 2.5.27), due to the structure of the Showcase and some of its examples, but I could not confirm that. I wanted to advise of what I saw, in case there might be a weird corner-case for "s:a" anchor tag processing that could produce unexpected warnings with 2.5.27.
If anyone has tried testing out an application with 2.5.27 which uses "s:a" tags, please let the dev list know if you see similar log warnings (and are not expecting to).
Regards,
James.
On 2021/10/26 12:48:29, Lukasz Lenart <lu...@apache.org> wrote:
> I assume there is no objection to starting the Vote.
>
> wt., 19 paź 2021 o 12:26 Greg Huber <gr...@gmail.com> napisał(a):
> >
> > They seem to download when I use maven-dependency-plugin.
> >
> > [INFO]
> > [INFO] --- maven-dependency-plugin:3.2.0:copy-dependencies
> > (copy-dependencies) @ events ---
> > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > for https://repo.maven.apache.org/maven2
> > [INFO] Downloading from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
> > [INFO] Downloaded from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
> > (4.3 kB at 53 kB/s)
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/_remote.repositories
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom.lastUpdated
> > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > for https://repo.maven.apache.org/maven2
> > [INFO] Downloading from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
> > [INFO] Downloaded from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
> > (9.8 kB at 656 kB/s)
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/_remote.repositories
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom.lastUpdated
> > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > for https://repo.maven.apache.org/maven2
> > [INFO] Downloading from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
> > [INFO] Downloaded from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
> > (12 kB at 845 kB/s)
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-master/4/_remote.repositories
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-master/4/struts-master-4.pom.lastUpdated
> > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > for https://repo.maven.apache.org/maven2
> > [INFO] Downloading from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
> > [INFO] Downloaded from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
> > (3.1 kB at 220 kB/s)
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/_remote.repositories
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom.lastUpdated
> > [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> > for https://repo.maven.apache.org/maven2
> > [INFO] Downloading from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
> > [INFO] Downloaded from :
> > https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
> > (2.9 kB at 208 kB/s)
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/_remote.repositories
> > [DEBUG] Writing tracking file
> > /home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom.lastUpdated
> > [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=427359,
> > ConflictMarker.markTime=174089, ConflictMarker.nodeCount=435,
> > ConflictIdSorter.graphTime=123092, ConflictIdSorter.topsortTime=76635,
> > ConflictIdSorter.conflictIdCount=93,
> > ConflictIdSorter.conflictIdCycleCount=0,
> > ConflictResolver.totalTime=1514331,
> > ConflictResolver.conflictItemCount=194,
> > DefaultDependencyCollector.collectTime=267604268,
> > DefaultDependencyCollector.transformTime=2378444}
> >
> >
> > I have scanned the .m2 struts folder, and their is nothing in the
> > struts2 poms using struts1
> >
> >
> > On 19/10/2021 10:29, Lukasz Lenart wrote:
> > > wt., 19 paź 2021 o 11:20 Greg Huber <gr...@gmail.com> napisał(a):
> > >> Also why in my ~.m2/repository/org/apache/struts folder I have struts 1
> > >> stuff? If I remove my repo above it still downloads them.
> > >>
> > >> struts-core, struts-master, struts-parent etc
> > >>
> > >> Maybe a maven thing?
> > > Some plugins can have transient dependencies on the Apache Struts 1,
> > > use `mvn dependency:tree` to track them down. It could also be
> > > Freemarker, Tiles or Spring.
> > >
> > >
> > > Regards
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.27 test build is ready
Posted by Lukasz Lenart <lu...@apache.org>.
I assume there is no objection to starting the Vote.
wt., 19 paź 2021 o 12:26 Greg Huber <gr...@gmail.com> napisał(a):
>
> They seem to download when I use maven-dependency-plugin.
>
> [INFO]
> [INFO] --- maven-dependency-plugin:3.2.0:copy-dependencies
> (copy-dependencies) @ events ---
> [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> for https://repo.maven.apache.org/maven2
> [INFO] Downloading from :
> https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
> [INFO] Downloaded from :
> https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
> (4.3 kB at 53 kB/s)
> [DEBUG] Writing tracking file
> /home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/_remote.repositories
> [DEBUG] Writing tracking file
> /home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom.lastUpdated
> [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> for https://repo.maven.apache.org/maven2
> [INFO] Downloading from :
> https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
> [INFO] Downloaded from :
> https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
> (9.8 kB at 656 kB/s)
> [DEBUG] Writing tracking file
> /home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/_remote.repositories
> [DEBUG] Writing tracking file
> /home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom.lastUpdated
> [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> for https://repo.maven.apache.org/maven2
> [INFO] Downloading from :
> https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
> [INFO] Downloaded from :
> https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
> (12 kB at 845 kB/s)
> [DEBUG] Writing tracking file
> /home/me/.m2/repository/org/apache/struts/struts-master/4/_remote.repositories
> [DEBUG] Writing tracking file
> /home/me/.m2/repository/org/apache/struts/struts-master/4/struts-master-4.pom.lastUpdated
> [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> for https://repo.maven.apache.org/maven2
> [INFO] Downloading from :
> https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
> [INFO] Downloaded from :
> https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
> (3.1 kB at 220 kB/s)
> [DEBUG] Writing tracking file
> /home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/_remote.repositories
> [DEBUG] Writing tracking file
> /home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom.lastUpdated
> [DEBUG] Using connector AetherRepositoryConnector with priority 100.0
> for https://repo.maven.apache.org/maven2
> [INFO] Downloading from :
> https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
> [INFO] Downloaded from :
> https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
> (2.9 kB at 208 kB/s)
> [DEBUG] Writing tracking file
> /home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/_remote.repositories
> [DEBUG] Writing tracking file
> /home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom.lastUpdated
> [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=427359,
> ConflictMarker.markTime=174089, ConflictMarker.nodeCount=435,
> ConflictIdSorter.graphTime=123092, ConflictIdSorter.topsortTime=76635,
> ConflictIdSorter.conflictIdCount=93,
> ConflictIdSorter.conflictIdCycleCount=0,
> ConflictResolver.totalTime=1514331,
> ConflictResolver.conflictItemCount=194,
> DefaultDependencyCollector.collectTime=267604268,
> DefaultDependencyCollector.transformTime=2378444}
>
>
> I have scanned the .m2 struts folder, and their is nothing in the
> struts2 poms using struts1
>
>
> On 19/10/2021 10:29, Lukasz Lenart wrote:
> > wt., 19 paź 2021 o 11:20 Greg Huber <gr...@gmail.com> napisał(a):
> >> Also why in my ~.m2/repository/org/apache/struts folder I have struts 1
> >> stuff? If I remove my repo above it still downloads them.
> >>
> >> struts-core, struts-master, struts-parent etc
> >>
> >> Maybe a maven thing?
> > Some plugins can have transient dependencies on the Apache Struts 1,
> > use `mvn dependency:tree` to track them down. It could also be
> > Freemarker, Tiles or Spring.
> >
> >
> > Regards
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.27 test build is ready
Posted by Greg Huber <gr...@gmail.com>.
They seem to download when I use maven-dependency-plugin.
[INFO]
[INFO] --- maven-dependency-plugin:3.2.0:copy-dependencies
(copy-dependencies) @ events ---
[DEBUG] Using connector AetherRepositoryConnector with priority 100.0
for https://repo.maven.apache.org/maven2
[INFO] Downloading from :
https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
[INFO] Downloaded from :
https://repo.maven.apache.org/maven2/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom
(4.3 kB at 53 kB/s)
[DEBUG] Writing tracking file
/home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/_remote.repositories
[DEBUG] Writing tracking file
/home/me/.m2/repository/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.pom.lastUpdated
[DEBUG] Using connector AetherRepositoryConnector with priority 100.0
for https://repo.maven.apache.org/maven2
[INFO] Downloading from :
https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
[INFO] Downloaded from :
https://repo.maven.apache.org/maven2/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom
(9.8 kB at 656 kB/s)
[DEBUG] Writing tracking file
/home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/_remote.repositories
[DEBUG] Writing tracking file
/home/me/.m2/repository/org/apache/struts/struts-parent/1.3.8/struts-parent-1.3.8.pom.lastUpdated
[DEBUG] Using connector AetherRepositoryConnector with priority 100.0
for https://repo.maven.apache.org/maven2
[INFO] Downloading from :
https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
[INFO] Downloaded from :
https://repo.maven.apache.org/maven2/org/apache/struts/struts-master/4/struts-master-4.pom
(12 kB at 845 kB/s)
[DEBUG] Writing tracking file
/home/me/.m2/repository/org/apache/struts/struts-master/4/_remote.repositories
[DEBUG] Writing tracking file
/home/me/.m2/repository/org/apache/struts/struts-master/4/struts-master-4.pom.lastUpdated
[DEBUG] Using connector AetherRepositoryConnector with priority 100.0
for https://repo.maven.apache.org/maven2
[INFO] Downloading from :
https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
[INFO] Downloaded from :
https://repo.maven.apache.org/maven2/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom
(3.1 kB at 220 kB/s)
[DEBUG] Writing tracking file
/home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/_remote.repositories
[DEBUG] Writing tracking file
/home/me/.m2/repository/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.pom.lastUpdated
[DEBUG] Using connector AetherRepositoryConnector with priority 100.0
for https://repo.maven.apache.org/maven2
[INFO] Downloading from :
https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
[INFO] Downloaded from :
https://repo.maven.apache.org/maven2/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom
(2.9 kB at 208 kB/s)
[DEBUG] Writing tracking file
/home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/_remote.repositories
[DEBUG] Writing tracking file
/home/me/.m2/repository/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.pom.lastUpdated
[DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=427359,
ConflictMarker.markTime=174089, ConflictMarker.nodeCount=435,
ConflictIdSorter.graphTime=123092, ConflictIdSorter.topsortTime=76635,
ConflictIdSorter.conflictIdCount=93,
ConflictIdSorter.conflictIdCycleCount=0,
ConflictResolver.totalTime=1514331,
ConflictResolver.conflictItemCount=194,
DefaultDependencyCollector.collectTime=267604268,
DefaultDependencyCollector.transformTime=2378444}
I have scanned the .m2 struts folder, and their is nothing in the
struts2 poms using struts1
On 19/10/2021 10:29, Lukasz Lenart wrote:
> wt., 19 paź 2021 o 11:20 Greg Huber <gr...@gmail.com> napisał(a):
>> Also why in my ~.m2/repository/org/apache/struts folder I have struts 1
>> stuff? If I remove my repo above it still downloads them.
>>
>> struts-core, struts-master, struts-parent etc
>>
>> Maybe a maven thing?
> Some plugins can have transient dependencies on the Apache Struts 1,
> use `mvn dependency:tree` to track them down. It could also be
> Freemarker, Tiles or Spring.
>
>
> Regards
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.27 test build is ready
Posted by Greg Huber <gr...@gmail.com>.
..
[INFO] +- org.apache.struts:struts2-core:jar:2.5.27:compile
[INFO] | +- org.freemarker:freemarker:jar:2.3.30:compile
[INFO] | +- ognl:ognl:jar:3.1.29:compile
[INFO] | | \- org.javassist:javassist:jar:3.20.0-GA:compile
[INFO] | \- commons-fileupload:commons-fileupload:jar:1.4:compile
[INFO] +- org.apache.struts:struts2-tiles-plugin:jar:2.5.27:compile
[INFO] | +- org.apache.tiles:tiles-api:jar:3.0.8:compile
[INFO] | +- org.apache.tiles:tiles-core:jar:3.0.8:compile
[INFO] | +- org.apache.tiles:tiles-servlet:jar:3.0.8:compile
[INFO] | +- org.apache.tiles:tiles-request-api:jar:1.0.7:compile
[INFO] | +- org.apache.tiles:tiles-request-jsp:jar:1.0.7:compile
[INFO] | +- org.apache.tiles:tiles-request-servlet:jar:1.0.7:compile
[INFO] | +- org.apache.tiles:tiles-jsp:jar:3.0.8:compile
[INFO] | | \- org.apache.tiles:tiles-template:jar:3.0.8:compile
[INFO] | | \-
org.apache.tiles:tiles-autotag-core-runtime:jar:1.2:compile
[INFO] | +- org.apache.tiles:tiles-freemarker:jar:3.0.8:compile
[INFO] | | \- org.apache.tiles:tiles-request-freemarker:jar:1.0.7:compile
[INFO] | +- org.apache.tiles:tiles-ognl:jar:3.0.8:compile
[INFO] | \- org.apache.tiles:tiles-el:jar:3.0.8:compile
[INFO] +- org.apache.struts:struts2-javatemplates-plugin:jar:2.5.27:compile
...
This is the output for org.apache.struts, no struts1
On 19/10/2021 10:29, Lukasz Lenart wrote:
> mvn dependency:tree
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.27 test build is ready
Posted by Lukasz Lenart <lu...@apache.org>.
wt., 19 paź 2021 o 11:20 Greg Huber <gr...@gmail.com> napisał(a):
> Also why in my ~.m2/repository/org/apache/struts folder I have struts 1
> stuff? If I remove my repo above it still downloads them.
>
> struts-core, struts-master, struts-parent etc
>
> Maybe a maven thing?
Some plugins can have transient dependencies on the Apache Struts 1,
use `mvn dependency:tree` to track them down. It could also be
Freemarker, Tiles or Spring.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.27 test build is ready
Posted by Greg Huber <gr...@gmail.com>.
<repository>
<id>apache.snapshots</id>
<name>ASF Maven 2 Snapshot</name>
<url>https://repository.apache.org/content/groups/staging/</url>
<releases>
<enabled>*true*</enabled>
<updatePolicy>always</updatePolicy>
<checksumPolicy>warn</checksumPolicy>
</releases>
<snapshots>
<enabled>false</enabled>
<updatePolicy>always</updatePolicy>
<checksumPolicy>warn</checksumPolicy>
</snapshots>
</repository>
Ok thanks, for me I change <releases> to true😁.
##
Also why in my ~.m2/repository/org/apache/struts folder I have struts 1
stuff? If I remove my repo above it still downloads them.
struts-core, struts-master, struts-parent etc
Maybe a maven thing?
Cheers Greg
On 19/10/2021 10:02, Lukasz Lenart wrote:
> wt., 19 paź 2021 o 10:46 Greg Huber<gr...@gmail.com> napisał(a):
>> Has the maven url's changed, as I get
>>
>> [WARNING] The POM for org.apache.struts:struts2-core:jar:2.5.27 is
>> missing, no dependency information available
>> [WARNING] The POM for org.apache.struts:struts2-tiles-plugin:jar:2.5.27
>> is missing, no dependency information available
>> [WARNING] The POM for
>> org.apache.struts:struts2-javatemplates-plugin:jar:2.5.27 is missing, no
>> dependency information available
>>
>> normally all I do is change the version and it works.
> This version is not officially released yet, so it's not available in
> the Maven Central repository. Add the below snippet in
> ~/.m2/repository to be able to fetch this build from staging repo:
>
> <settings>
> ...
> <profiles>
> <profile>
> <id>local</id>
> <activation>
> <activeByDefault>true</activeByDefault>
> </activation>
> <repositories>
> <repository>
> <id>apache-pre-release</id>
>
> <url>https://repository.apache.org/content/repositories/staging/</url>
> <layout>default</layout>
> </repository>
> </repositories>
> </profile>
> </profiles>
> </settings>
>
> I'm going add a note about this here
> https://struts.apache.org/builds.html#test-builds
>
>
> Regards
Re: [TEST] Struts 2.5.27 test build is ready
Posted by Lukasz Lenart <lu...@apache.org>.
wt., 19 paź 2021 o 10:46 Greg Huber <gr...@gmail.com> napisał(a):
>
> Has the maven url's changed, as I get
>
> [WARNING] The POM for org.apache.struts:struts2-core:jar:2.5.27 is
> missing, no dependency information available
> [WARNING] The POM for org.apache.struts:struts2-tiles-plugin:jar:2.5.27
> is missing, no dependency information available
> [WARNING] The POM for
> org.apache.struts:struts2-javatemplates-plugin:jar:2.5.27 is missing, no
> dependency information available
>
> normally all I do is change the version and it works.
This version is not officially released yet, so it's not available in
the Maven Central repository. Add the below snippet in
~/.m2/repository to be able to fetch this build from staging repo:
<settings>
...
<profiles>
<profile>
<id>local</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<repositories>
<repository>
<id>apache-pre-release</id>
<url>https://repository.apache.org/content/repositories/staging/</url>
<layout>default</layout>
</repository>
</repositories>
</profile>
</profiles>
</settings>
I'm going add a note about this here
https://struts.apache.org/builds.html#test-builds
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: [TEST] Struts 2.5.27 test build is ready
Posted by Greg Huber <gr...@gmail.com>.
Has the maven url's changed, as I get
[WARNING] The POM for org.apache.struts:struts2-core:jar:2.5.27 is
missing, no dependency information available
[WARNING] The POM for org.apache.struts:struts2-tiles-plugin:jar:2.5.27
is missing, no dependency information available
[WARNING] The POM for
org.apache.struts:struts2-javatemplates-plugin:jar:2.5.27 is missing, no
dependency information available
normally all I do is change the version and it works.
On 19/10/2021 09:18, Lukasz Lenart wrote:
> Hi,
>
> Please take a time and test the bits - any help is appreciated. Please
> report any problems. I'll call for a vote in a few days if no problems
> will be spotted.
>
> Staging Maven repo
> https://repository.apache.org/content/groups/staging/
>
> Standalone artifacts
> https://dist.apache.org/repos/dist/dev/struts/2.5.27/
>
> Release notes
> https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.27
>
>
> Kind regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org