[jira] [Resolved] (ARROW-6515) [C++] Clean type_traits.h definitions

["Francois Saint-Jacques (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARROW-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francois Saint-Jacques resolved ARROW-6515.
-------------------------------------------
    Resolution: Fixed

Issue resolved by pull request 5885
[https://github.com/apache/arrow/pull/5885]

> [C++] Clean type_traits.h definitions
> -------------------------------------
>
>                 Key: ARROW-6515
>                 URL: https://issues.apache.org/jira/browse/ARROW-6515
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Ben Kietzman
>            Assignee: Francois Saint-Jacques
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.0.0
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> {{IsSignedInt}} takes either an array or a type as a type argument, which is surprisingly atypical for traits. Furthermore whereas {{is_signed_integer}} returns false for date and other types which are represented by but not identical to integers {{IsSignedInt}} returns true by checking only the {{c_type}}, which leads to {{static_assert(IsSignedInt<HalfFloatType>::value, "")}}. Finally the declaration of {{IsSignedInt}} is far from readable due to nested macro usage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)