You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Rob Oxspring <ro...@imapmail.org> on 2005/04/04 18:12:30 UTC
[io][patch] skip() support for CountingInputStream
Hi,
I recently replaced the use of my own CountingInputStream with the commons-io
and got burnt because io's CountingInputStream doesn't count skipped bytes. I
have a patch with fix and patch if people are interested... or I could just
commit it...
Thoughts?
Rob
Re: [io][patch] skip() support for CountingInputStream
Posted by Rob Oxspring <ro...@imapmail.org>.
Ok, Am logging it in bugzilla but will commit shortly.
Rob
Henri Yandell wrote:
> Whoops :)
>
> Definitely a bug, I'd not even bother to add yourself to the committer
> list if you didn't want to just commit away. Nice to add to bugzilla
> though and go through the motions so it can more easily appear in a
> release-notes. Especially if we're using the changes.xml bit.
>
> Hen
>
> On Apr 5, 2005 9:57 AM, matthew.hawthorne <ma...@apache.org> wrote:
>
>>Rob Oxspring wrote:
>>
>>>I recently replaced the use of my own CountingInputStream with the
>>>commons-io and got burnt because io's CountingInputStream doesn't count
>>>skipped bytes. I have a patch with fix and patch if people are
>>>interested... or I could just commit it...
>>>
>>>Thoughts?
>>
>>I am not familiar with this class, but as a general rule, I would
>>suggest that you either submit the class as an enhancement in Bugzilla,
>>or add yourself to the committers list and commit it.
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [io][patch] skip() support for CountingInputStream
Posted by Henri Yandell <fl...@gmail.com>.
Whoops :)
Definitely a bug, I'd not even bother to add yourself to the committer
list if you didn't want to just commit away. Nice to add to bugzilla
though and go through the motions so it can more easily appear in a
release-notes. Especially if we're using the changes.xml bit.
Hen
On Apr 5, 2005 9:57 AM, matthew.hawthorne <ma...@apache.org> wrote:
> Rob Oxspring wrote:
> > I recently replaced the use of my own CountingInputStream with the
> > commons-io and got burnt because io's CountingInputStream doesn't count
> > skipped bytes. I have a patch with fix and patch if people are
> > interested... or I could just commit it...
> >
> > Thoughts?
>
> I am not familiar with this class, but as a general rule, I would
> suggest that you either submit the class as an enhancement in Bugzilla,
> or add yourself to the committers list and commit it.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [io][patch] skip() support for CountingInputStream
Posted by "matthew.hawthorne" <ma...@apache.org>.
Rob Oxspring wrote:
> I recently replaced the use of my own CountingInputStream with the
> commons-io and got burnt because io's CountingInputStream doesn't count
> skipped bytes. I have a patch with fix and patch if people are
> interested... or I could just commit it...
>
> Thoughts?
I am not familiar with this class, but as a general rule, I would
suggest that you either submit the class as an enhancement in Bugzilla,
or add yourself to the committers list and commit it.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org