You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/31 21:05:07 UTC
[GitHub] [pulsar] dave2wave opened a new pull request #14976: Fix performance regression in pulsar client 2.8.3
dave2wave opened a new pull request #14976:
URL: https://github.com/apache/pulsar/pull/14976
### Motivation
While doing OMB tests of the 2.8.3 Pulsar client the consumer workers could no longer perform at 1,000,000 messages per second in our test configuration.
### Modifications
Reverted with edits https://github.com/apache/pulsar/commit/e134e372b3cc007bb507f04076011407cc28b7c0
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
Please pay attention to moving code that adds extra work to a thread.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [X] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on pull request #14976: Fix performance regression in pulsar client 2.8.3
Posted by GitBox <gi...@apache.org>.
dave2wave commented on pull request #14976:
URL: https://github.com/apache/pulsar/pull/14976#issuecomment-1086041498
> so basically you are saying that this commit #13023
>
> introduce a non negligible performance regression ?
Exactly a cluster that can easily consume 1,000,000 100 byte msgs/sec can only consume around 900,000 (it fluctuates because it is cpu bound) With this change the behavior looks like 2.8.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on pull request #14976: Fix performance regression in pulsar client 2.8.3
Posted by GitBox <gi...@apache.org>.
dave2wave commented on pull request #14976:
URL: https://github.com/apache/pulsar/pull/14976#issuecomment-1086037074
> probably there is a problem with GH, the overall patch looks empty
The problem is that I thought the branch was protected and made a commit from GitHub Desktop that I expected would trigger a PR and it did not. This meant that somehow this PR picked up the revert of the prior commit. GItHub is sometimes painful. Look into the commits to see the actual intention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #14976: Fix performance regression in pulsar client 2.8.3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #14976:
URL: https://github.com/apache/pulsar/pull/14976#issuecomment-1085492283
please @dave2wave send the PR against master branch, then we will cherry-pick to all active branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #14976: Fix performance regression in pulsar client 2.8.3
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #14976:
URL: https://github.com/apache/pulsar/pull/14976#issuecomment-1085672696
Hi, I also found a performance regression in Pulsar client 2.9.1 (compared with 2.8.1). I'm not sure if it's related to https://github.com/apache/pulsar/pull/13023, I'll have a test first.
BTW, I think #13023 is a bug fix, could you find another way to fix the bug? And could you explain more about why #13023 introduced a performance regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #14976: Fix performance regression in pulsar client 2.8.3
Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #14976:
URL: https://github.com/apache/pulsar/pull/14976#issuecomment-1086473662
Message ordering issue is kind of a feature bug, and normally it's more critical to most of applications. So just revert this is not the best option here. Maybe we should find a way to optimize the performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #14976: Fix performance regression in pulsar client 2.8.3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #14976:
URL: https://github.com/apache/pulsar/pull/14976#issuecomment-1085490999
so basically you are saying that this commit
https://github.com/apache/pulsar/pull/13023
introduce a non negligible performance regression ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org