You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/16 09:07:07 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #8885: Fix master failing on generating requirements

mik-laj commented on a change in pull request #8885:
URL: https://github.com/apache/airflow/pull/8885#discussion_r426135444



##########
File path: backport_packages/setup_backport_packages.py
##########
@@ -988,7 +988,13 @@ def update_release_notes_for_package(provider_package_id: str, current_release_v
     git_cmd = get_git_command(previous_release)
     changes = subprocess.check_output(git_cmd, cwd=provider_package_path, universal_newlines=True)
     if changes == "":
-        print(f"The code has not changed since last release {last_release}. Skipping generating README.")
+        print(f"No change since {last_release}")
+        print("Skipping generating README.")
+        return
+    if len(changes.splitlines() == 1):

Review comment:
       ```suggestion
       if len(changes.splitlines()) == 1:
   ```
   ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org