You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/09/15 08:03:33 UTC

[GitHub] [ozone] siddhantsangwan commented on pull request #3751: HDDS-6492 Add metric for failed container moves.

siddhantsangwan commented on PR #3751:
URL: https://github.com/apache/ozone/pull/3751#issuecomment-1247730996

   Overall, I think it's better to count failed moves in the `whenComplete((result, ex)` stage of completable future in the `moveContainer` method. That way, we can count all the failures at one place. `checkIterationMoveResults` can be used for updating aggregate metrics (across all iterations). @sumitagrawl What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org