You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Sandish Kumar HN <sa...@gmail.com> on 2017/08/22 13:49:29 UTC
Review Request 61814: SQOOP-2907 : SQOOP export from Hive table to
RDBMS CLOB and BLOB CLOUMNS
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61814/
-----------------------------------------------------------
Review request for Sqoop and Anna Szonyi.
Bugs: SQOOP-3132
https://issues.apache.org/jira/browse/SQOOP-3132
Repository: sqoop-trunk
Description
-------
SQOOP export from Hive table to RDBMS CLOB and BLOB CLOUMNS.
export a String column from Hive table to RDBS CLOB/BLOB data type column using sqoop export.
Diffs
-----
src/java/org/apache/sqoop/lib/JdbcWritableBridge.java afde5855
src/java/org/apache/sqoop/lib/LobRef.java d6d6b253
src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatExportHelper.java 57a90b0a
Diff: https://reviews.apache.org/r/61814/diff/1/
Testing
-------
Thanks,
Sandish Kumar HN
Re: Review Request 61814: SQOOP-2907 : SQOOP export from Hive table
to RDBMS CLOB and BLOB CLOUMNS
Posted by Anna Szonyi <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61814/#review183479
-----------------------------------------------------------
Hi Sandish,
Could you please add some test cases to this? Maybe on top of the existing HCatalogExportTests or a new test class.
Thanks,
Anna
- Anna Szonyi
On Aug. 22, 2017, 1:49 p.m., Sandish Kumar HN wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61814/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 1:49 p.m.)
>
>
> Review request for Sqoop and Anna Szonyi.
>
>
> Bugs: SQOOP-3132
> https://issues.apache.org/jira/browse/SQOOP-3132
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP export from Hive table to RDBMS CLOB and BLOB CLOUMNS.
> export a String column from Hive table to RDBS CLOB/BLOB data type column using sqoop export.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/lib/JdbcWritableBridge.java afde5855
> src/java/org/apache/sqoop/lib/LobRef.java d6d6b253
> src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatExportHelper.java 57a90b0a
>
>
> Diff: https://reviews.apache.org/r/61814/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sandish Kumar HN
>
>
Re: Review Request 61814: SQOOP-3132 : SQOOP export from Hive table
to RDBMS CLOB and BLOB CLOUMNS
Posted by Boglarka Egyed <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61814/#review191178
-----------------------------------------------------------
Hi Sandish,
I ran unit and 3rd party tests with your patch as a first check and it seems that your change breaks many things, the following 3rd party tests failed:
* com.cloudera.sqoop.manager.MySQLCompatTest
* com.cloudera.sqoop.manager.MySQLLobAvroImportTest
* com.cloudera.sqoop.manager.OracleCompatTest
* com.cloudera.sqoop.manager.OracleLobAvroImportTest
* org.apache.sqoop.hcat.HCatalogImportTest
* org.apache.sqoop.manager.cubrid.CubridCompatTest
* org.apache.sqoop.manager.oracle.SystemImportTest
Please review your change and make sure that all the unit and 3rd party tests are green before submitting it to review. Fortunately 3rd party test execution is much easier since those have been dockerized, for a guideline to run them please see the COMPILING.txt document.
Thank you,
Bogi
- Boglarka Egyed
On Aug. 22, 2017, 6:06 p.m., Sandish Kumar HN wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61814/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 6:06 p.m.)
>
>
> Review request for Sqoop and Anna Szonyi.
>
>
> Bugs: SQOOP-3132
> https://issues.apache.org/jira/browse/SQOOP-3132
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> SQOOP export from Hive table to RDBMS CLOB and BLOB CLOUMNS.
> export a String column from Hive table to RDBS CLOB/BLOB data type column using sqoop export.
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/lib/JdbcWritableBridge.java 316547f1
> src/java/org/apache/sqoop/lib/JdbcWritableBridge.java afde5855
> src/java/org/apache/sqoop/lib/LobRef.java d6d6b253
> src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatExportHelper.java 57a90b0a
> src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 7ff046ef
>
>
> Diff: https://reviews.apache.org/r/61814/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sandish Kumar HN
>
>
Re: Review Request 61814: SQOOP-3132 : SQOOP export from Hive table
to RDBMS CLOB and BLOB CLOUMNS
Posted by Sandish Kumar HN <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61814/
-----------------------------------------------------------
(Updated Aug. 22, 2017, 6:06 p.m.)
Review request for Sqoop and Anna Szonyi.
Bugs: SQOOP-3132
https://issues.apache.org/jira/browse/SQOOP-3132
Repository: sqoop-trunk
Description
-------
SQOOP export from Hive table to RDBMS CLOB and BLOB CLOUMNS.
export a String column from Hive table to RDBS CLOB/BLOB data type column using sqoop export.
Diffs (updated)
-----
src/java/com/cloudera/sqoop/lib/JdbcWritableBridge.java 316547f1
src/java/org/apache/sqoop/lib/JdbcWritableBridge.java afde5855
src/java/org/apache/sqoop/lib/LobRef.java d6d6b253
src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatExportHelper.java 57a90b0a
src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 7ff046ef
Diff: https://reviews.apache.org/r/61814/diff/4/
Changes: https://reviews.apache.org/r/61814/diff/3-4/
Testing
-------
Thanks,
Sandish Kumar HN
Re: Review Request 61814: SQOOP-3132 : SQOOP export from Hive table
to RDBMS CLOB and BLOB CLOUMNS
Posted by Sandish Kumar HN <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61814/
-----------------------------------------------------------
(Updated Aug. 22, 2017, 5:40 p.m.)
Review request for Sqoop and Anna Szonyi.
Bugs: SQOOP-3132
https://issues.apache.org/jira/browse/SQOOP-3132
Repository: sqoop-trunk
Description
-------
SQOOP export from Hive table to RDBMS CLOB and BLOB CLOUMNS.
export a String column from Hive table to RDBS CLOB/BLOB data type column using sqoop export.
Diffs (updated)
-----
src/java/org/apache/sqoop/lib/JdbcWritableBridge.java afde5855
src/java/org/apache/sqoop/lib/LobRef.java d6d6b253
src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatExportHelper.java 57a90b0a
src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 7ff046ef
Diff: https://reviews.apache.org/r/61814/diff/3/
Changes: https://reviews.apache.org/r/61814/diff/2-3/
Testing
-------
Thanks,
Sandish Kumar HN
Re: Review Request 61814: SQOOP-3132 : SQOOP export from Hive table
to RDBMS CLOB and BLOB CLOUMNS
Posted by Sandish Kumar HN <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61814/
-----------------------------------------------------------
(Updated Aug. 22, 2017, 5:38 p.m.)
Review request for Sqoop and Anna Szonyi.
Summary (updated)
-----------------
SQOOP-3132 : SQOOP export from Hive table to RDBMS CLOB and BLOB CLOUMNS
Bugs: SQOOP-3132
https://issues.apache.org/jira/browse/SQOOP-3132
Repository: sqoop-trunk
Description
-------
SQOOP export from Hive table to RDBMS CLOB and BLOB CLOUMNS.
export a String column from Hive table to RDBS CLOB/BLOB data type column using sqoop export.
Diffs (updated)
-----
src/java/org/apache/sqoop/lib/JdbcWritableBridge.java afde5855
src/java/org/apache/sqoop/lib/LobRef.java d6d6b253
src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatExportHelper.java 57a90b0a
src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 7ff046ef
Diff: https://reviews.apache.org/r/61814/diff/2/
Changes: https://reviews.apache.org/r/61814/diff/1-2/
Testing
-------
Thanks,
Sandish Kumar HN