You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/18 10:15:03 UTC
[GitHub] klion26 commented on a change in pull request #7729: [FLINK-11643]
remove useless code of externalizedCheckpointsDir
klion26 commented on a change in pull request #7729: [FLINK-11643] remove useless code of externalizedCheckpointsDir
URL: https://github.com/apache/flink/pull/7729#discussion_r257632289
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackendLoader.java
##########
@@ -104,22 +104,23 @@ public static StateBackend loadStateBackendFromConfig(
// by default the factory class is the backend name
String factoryClassName = backendName;
+ final boolean logIsNotNull = logger != null;
switch (backendName.toLowerCase()) {
case MEMORY_STATE_BACKEND_NAME:
MemoryStateBackend memBackend = new MemoryStateBackendFactory().createFromConfig(config);
- if (logger != null) {
+ if (logIsNotNull) {
Review comment:
As you have changed this, should we add a test logic that is info log enabled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services