[GitHub] [solr] HoustonPutman commented on a change in pull request #423: SOLR-15808: The jattach tool for Docker image is now installed with apt

[GitBox <gi...@apache.org>]

HoustonPutman commented on a change in pull request #423:
URL: https://github.com/apache/solr/pull/423#discussion_r752478848



##########
File path: solr/docker/templates/Dockerfile.body.template
##########
@@ -43,11 +43,8 @@ ARG GITHUB_URL=github.com
 
 RUN set -ex; \
     apt-get update; \
-    apt-get -y install acl dirmngr lsof procps wget netcat gosu tini; \
-    rm -rf /var/lib/apt/lists/*; \
-    cd /usr/local/bin; wget -nv https://${GITHUB_URL}/apangin/jattach/releases/download/v1.5/jattach; chmod 755 jattach; \

Review comment:
       We should be able to move the GITHUB_URL argument from the various places it's referenced




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org