You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "senthh (via GitHub)" <gi...@apache.org> on 2023/05/31 09:54:58 UTC
[GitHub] [solr] senthh opened a new pull request, #1673: MINOR: Document change to mention hadoop/Kerberos Plugins moved to package org.apache.solr.security.hadoop
senthh opened a new pull request, #1673:
URL: https://github.com/apache/solr/pull/1673
https://issues.apache.org/jira/browse/SOLR-16826
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Document change to mention hadoop/Kerberos Plugins moved to package org.apache.solr.security.hadoop
# Solution
Added document change in 'major-changes-in-solr-9.adoc file
# Tests
NA
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1673: MINOR: Document change to mention hadoop/Kerberos Plugins moved to package org.apache.solr.security.hadoop
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #1673:
URL: https://github.com/apache/solr/pull/1673#discussion_r1211573242
##########
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc:
##########
@@ -175,7 +175,7 @@ Administrators that need Solr exposed more broadly can change the `SOLR_JETTY_HO
If you rely upon the previous behavior, then you can change the `clientPortAddress` in `solr/server/solr/zoo.cfg`
* Jetty low level request-logging in NCSA format is now enabled by default, with a retention of 3 days worth of logs.
This may require some more disk space for logs than was the case in version 8.x. See xref:deployment-guide:configuring-logging.adoc[Configuring Logging] for how to change this.
-* Hadoop authentication support has been moved to the new `hadoop-auth` module. Existing Solr configurations do not need any Hadoop authentication related changes, however the module needs to be installed - see the section xref:deployment-guide:hadoop-authentication-plugin.adoc[].
+* Hadoop authentication support has been moved to the new `hadoop-auth` module. Users need to add the module hadoop-auth to classpath. The plugins has also changed package name to org.apache.solr.security.hadoop, but can still be loaded as shortform class="solr.HadoopAuthPlugin" or class="solr.ConfigurableInternodeAuthHadoopPlugin" or class="solr.KerberosPlugin" - see the section xref:deployment-guide:hadoop-authentication-plugin.adoc[].
Review Comment:
Code formatting:
```suggestion
* Hadoop authentication support has been moved to the new `hadoop-auth` module. Users need to add the module `hadoop-auth` to classpath. The plugins has also changed package name to `org.apache.solr.security.hadoop`, but can still be loaded as shortform `class="solr.HadoopAuthPlugin"`, `class="solr.ConfigurableInternodeAuthHadoopPlugin"` or `class="solr.KerberosPlugin"` - see the section xref:deployment-guide:hadoop-authentication-plugin.adoc[].
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1673: MINOR: Document change to mention hadoop/Kerberos Plugins moved to package org.apache.solr.security.hadoop
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #1673:
URL: https://github.com/apache/solr/pull/1673#issuecomment-1570429911
Thanks @janhoy !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #1673: MINOR: Document change to mention hadoop/Kerberos Plugins moved to package org.apache.solr.security.hadoop
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy merged PR #1673:
URL: https://github.com/apache/solr/pull/1673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1673: MINOR: Document change to mention hadoop/Kerberos Plugins moved to package org.apache.solr.security.hadoop
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on PR #1673:
URL: https://github.com/apache/solr/pull/1673#issuecomment-1571067452
Thanks @janhoy and @senthh - SOLR-13989 is what introduced this. When I looked through our docs nothing specifically had the full class always `solr.ABC` so it didn't occur to me to put this in the upgrade notes. Sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] senthh commented on a diff in pull request #1673: MINOR: Document change to mention hadoop/Kerberos Plugins moved to package org.apache.solr.security.hadoop
Posted by "senthh (via GitHub)" <gi...@apache.org>.
senthh commented on code in PR #1673:
URL: https://github.com/apache/solr/pull/1673#discussion_r1211721546
##########
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc:
##########
@@ -175,7 +175,7 @@ Administrators that need Solr exposed more broadly can change the `SOLR_JETTY_HO
If you rely upon the previous behavior, then you can change the `clientPortAddress` in `solr/server/solr/zoo.cfg`
* Jetty low level request-logging in NCSA format is now enabled by default, with a retention of 3 days worth of logs.
This may require some more disk space for logs than was the case in version 8.x. See xref:deployment-guide:configuring-logging.adoc[Configuring Logging] for how to change this.
-* Hadoop authentication support has been moved to the new `hadoop-auth` module. Existing Solr configurations do not need any Hadoop authentication related changes, however the module needs to be installed - see the section xref:deployment-guide:hadoop-authentication-plugin.adoc[].
+* Hadoop authentication support has been moved to the new `hadoop-auth` module. Users need to add the module hadoop-auth to classpath. The plugins has also changed package name to org.apache.solr.security.hadoop, but can still be loaded as shortform class="solr.HadoopAuthPlugin" or class="solr.ConfigurableInternodeAuthHadoopPlugin" or class="solr.KerberosPlugin" - see the section xref:deployment-guide:hadoop-authentication-plugin.adoc[].
Review Comment:
Thanks for the review @janhoy , I have modified as per your suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1673: MINOR: Document change to mention hadoop/Kerberos Plugins moved to package org.apache.solr.security.hadoop
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #1673:
URL: https://github.com/apache/solr/pull/1673#issuecomment-1570301729
This looks great to me. I can take care of backporting to all of the branches @janhoy , so that all versions of the ref guide get this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1673: MINOR: Document change to mention hadoop/Kerberos Plugins moved to package org.apache.solr.security.hadoop
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1673:
URL: https://github.com/apache/solr/pull/1673#issuecomment-1570922959
I merged to main, `9x`, `9_2`, `9_1` and `9_0`, think that are all the guide versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org