You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Angela Schreiber (Jira)" <ji...@apache.org> on 2021/05/26 06:33:00 UTC
[jira] [Commented] (SLING-10228) Unused property PROP_NODETYPES in
AclLine
[ https://issues.apache.org/jira/browse/SLING-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351540#comment-17351540 ]
Angela Schreiber commented on SLING-10228:
------------------------------------------
[~bdelacretaz], what is your take on this bug report? maybe you can elaborate what the intention behind the _nodetypes_ clause in the ACLLine was? I don't see it implemented and I don't understand what it was intended to be used for. In case there is no reason for having it, I would recommend to either drop it from repo-init language altogether or at least officially deprecated it and log a warning (or throw UnsupportedOperationException).
> Unused property PROP_NODETYPES in AclLine
> -----------------------------------------
>
> Key: SLING-10228
> URL: https://issues.apache.org/jira/browse/SLING-10228
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
> Reporter: Angela Schreiber
> Priority: Major
>
> while performing some initial investigations for SLING-10219, i noticed that {{AclLine}} comes with a property {{AclLine.PROP_NODETYPES}}.
> while i found the following example in _test-33.txt_ , i couldn't find any usage in _org.apache.sling.jcr.repoinit_ or a more detailed explanation:
> {code}
> # Optional nodetypes clause
> deny jcr:lockManagement on /apps, /content nodetypes sling:Folder, nt:unstructured
> # nodetypes clause with restriction clause
> deny jcr:modifyProperties on /apps, /content nodetypes sling:Folder, nt:unstructured restriction(rep:itemNames,prop1,prop2)
> {code}
>
> therefore, i am bit lost what the intention behind that optional 'nodetypes' property would be in the first place as there exists no 'nodetypes' property with any type of access control entry defined by either JCR or Jackrabbit API.
> i would therefore suggest to deprecate and ignore it upon parsing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)