You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/18 20:32:03 UTC
[GitHub] [airflow] dstandish opened a new pull request, #27120: Make pod name optional in KubernetesPodOperator
dstandish opened a new pull request, #27120:
URL: https://github.com/apache/airflow/pull/27120
When not provided, let's just use the task name, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #27120: Make pod name optional in KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
dstandish commented on code in PR #27120:
URL: https://github.com/apache/airflow/pull/27120#discussion_r998729876
##########
airflow/providers/cncf/kubernetes/CHANGELOG.rst:
##########
@@ -32,6 +32,11 @@ Breaking changes
Previously KubernetesPodOperator considered some settings from the Airflow config's ``kubernetes`` section. Such consideration was deprecated in 4.1.0 and is now removed. If you previously relied on the Airflow config, and you want client generation to have non-default configuration, you will need to define your configuration in an Airflow connection and set KPO to use the connection. See kubernetes provider documentation on defining a kubernetes Airflow connection for details.
+Features
+~~~~~~~~
+
+Previously, ``namespace`` and ``name`` were required arguments for KubernetesPodOperator. Now, if ``name`` is not supplied, ``task_id`` will be used. And if ``namespace`` is not supplied, and the task is running in a cluster, then the task pod's namespace will be used.
Review Comment:
true, i'll clean it up in the namespace one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #27120: Make pod name optional in KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
dstandish commented on code in PR #27120:
URL: https://github.com/apache/airflow/pull/27120#discussion_r1001908513
##########
airflow/providers/cncf/kubernetes/CHANGELOG.rst:
##########
@@ -32,6 +32,11 @@ Breaking changes
Previously KubernetesPodOperator considered some settings from the Airflow config's ``kubernetes`` section. Such consideration was deprecated in 4.1.0 and is now removed. If you previously relied on the Airflow config, and you want client generation to have non-default configuration, you will need to define your configuration in an Airflow connection and set KPO to use the connection. See kubernetes provider documentation on defining a kubernetes Airflow connection for details.
+Features
+~~~~~~~~
+
+Previously, ``namespace`` and ``name`` were required arguments for KubernetesPodOperator. Now, if ``name`` is not supplied, ``task_id`` will be used. And if ``namespace`` is not supplied, and the task is running in a cluster, then the task pod's namespace will be used.
Review Comment:
actually, had to fix something anyway so clarified here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #27120: Make pod name optional in KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #27120:
URL: https://github.com/apache/airflow/pull/27120#discussion_r998725827
##########
airflow/providers/cncf/kubernetes/CHANGELOG.rst:
##########
@@ -32,6 +32,11 @@ Breaking changes
Previously KubernetesPodOperator considered some settings from the Airflow config's ``kubernetes`` section. Such consideration was deprecated in 4.1.0 and is now removed. If you previously relied on the Airflow config, and you want client generation to have non-default configuration, you will need to define your configuration in an Airflow connection and set KPO to use the connection. See kubernetes provider documentation on defining a kubernetes Airflow connection for details.
+Features
+~~~~~~~~
+
+Previously, ``namespace`` and ``name`` were required arguments for KubernetesPodOperator. Now, if ``name`` is not supplied, ``task_id`` will be used. And if ``namespace`` is not supplied, and the task is running in a cluster, then the task pod's namespace will be used.
Review Comment:
mmm was name mandatory for KPO? I think it was optional because it could have been defined in pod template
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish merged pull request #27120: Make pod name optional in KubernetesPodOperator
Posted by GitBox <gi...@apache.org>.
dstandish merged PR #27120:
URL: https://github.com/apache/airflow/pull/27120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org