You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@griffin.apache.org by toyboxman <gi...@git.apache.org> on 2018/08/05 04:38:27 UTC

[GitHub] incubator-griffin pull request #384: Initialize java code checks rules for g...

GitHub user toyboxman opened a pull request:

    https://github.com/apache/incubator-griffin/pull/384

    Initialize java code checks rules for griffin

    this config could be used by maven checkStyle plugin

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/toyboxman/incubator-griffin checkstyle

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-griffin/pull/384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #384
    
----
commit a3708b6856efc53572aad6a6178697dab5ed718d
Author: Eugene <to...@...>
Date:   2018-08-05T04:35:03Z

    Initialize java code checks rules for griffin
    
    this config could be used by maven checkStyle plugin

----


---

[GitHub] incubator-griffin pull request #384: Initialize java code checks rules for g...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-griffin/pull/384


---

[GitHub] incubator-griffin issue #384: Initialize java code checks rules for griffin

Posted by toyboxman <gi...@git.apache.org>.

Github user toyboxman commented on the issue:

    https://github.com/apache/incubator-griffin/pull/384
  
    I agree with you @guoyuepeng 
    
    actually a code style guide is better than code template here. I will revise this patch


---

[GitHub] incubator-griffin issue #384: Initialize java code checks rules for griffin

Posted by guoyuepeng <gi...@git.apache.org>.

Github user guoyuepeng commented on the issue:

    https://github.com/apache/incubator-griffin/pull/384
  
    @toyboxman 


---

[GitHub] incubator-griffin issue #384: Initialize java code checks rules for griffin

Posted by toyboxman <gi...@git.apache.org>.

Github user toyboxman commented on the issue:

    https://github.com/apache/incubator-griffin/pull/384
  
    @guoyuepeng 
    
    I append guide part about how to enable style-check in maven and idea. I think we can add scala and type script code style rule here as well
    
    thanks


---