[GitHub] [airflow] ashb commented on a diff in pull request #26230: Allow to override version suffix in CI

[GitBox <gi...@apache.org>]

ashb commented on code in PR #26230:
URL: https://github.com/apache/airflow/pull/26230#discussion_r965775255


##########
scripts/in_container/run_prepare_airflow_packages.sh:
##########
@@ -55,9 +55,10 @@ function prepare_airflow_packages() {
         else
             if [[ ${AIRFLOW_VERSION} != *${VERSION_SUFFIX_FOR_PYPI} ]]; then
                 echo
-                echo "${COLOR_RED}The requested PyPI suffix ${VERSION_SUFFIX_FOR_PYPI} does not match the one in ${AIRFLOW_VERSION}. Exiting.${COLOR_RESET}"
+                echo "${COLOR_YELLOW}The requested PyPI suffix ${VERSION_SUFFIX_FOR_PYPI} does not match the one in ${AIRFLOW_VERSION}. Overriding it with one from ${AIRFLOW_VERSION}.${COLOR_RESET}"
                 echo
-                exit 1
+                VERSION_SUFFIX_FOR_PYPI=$(printf "%s\n" "${AIRFLOW_VERSION##*.}")

Review Comment:
   Wouldn't this set the suffix to `0b1`? (`2.4.0b1` -> `0b1`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org