[GitHub] [incubator-mxnet] asmushetzel opened a new pull request #16428: fixed gradient computation of activation softrelu

[GitBox <gi...@apache.org>]

asmushetzel opened a new pull request #16428: fixed gradient computation of activation softrelu
URL: https://github.com/apache/incubator-mxnet/pull/16428
 
 
   ## Description ##
   The code for the gradient of the activation of type "softrelu" is wrong. This most likely lead to the flaky tests referenced in #13915 which failed exactly in the gradient checking. Unfortunately these tests where then simply disabled by PR 14969 instead of root causing it. This fix adds correct gradient computation and re-enables the tests.
   
   ## Checklist ##
   ### Essentials ###
   - [X ] Changes are complete (i.e. I finished coding on this PR)
   - [X ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [X ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services