You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2015/07/28 18:42:38 UTC
spark git commit: [SPARK-9402][SQL] Remove CodegenFallback from Abs /
FormatNumber.
Repository: spark
Updated Branches:
refs/heads/master 4af622c85 -> 5a2330e54
[SPARK-9402][SQL] Remove CodegenFallback from Abs / FormatNumber.
Both expressions already implement code generation.
Author: Reynold Xin <rx...@databricks.com>
Closes #7723 from rxin/abs-formatnum and squashes the following commits:
31ed765 [Reynold Xin] [SPARK-9402][SQL] Remove CodegenFallback from Abs / FormatNumber.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/5a2330e5
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/5a2330e5
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/5a2330e5
Branch: refs/heads/master
Commit: 5a2330e546074013ef706ac09028626912ec5475
Parents: 4af622c
Author: Reynold Xin <rx...@databricks.com>
Authored: Tue Jul 28 09:42:35 2015 -0700
Committer: Reynold Xin <rx...@databricks.com>
Committed: Tue Jul 28 09:42:35 2015 -0700
----------------------------------------------------------------------
.../org/apache/spark/sql/catalyst/expressions/arithmetic.scala | 3 +--
.../apache/spark/sql/catalyst/expressions/stringOperations.scala | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/5a2330e5/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
index b37f530..4ec8664 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
@@ -68,8 +68,7 @@ case class UnaryPositive(child: Expression) extends UnaryExpression with Expects
@ExpressionDescription(
usage = "_FUNC_(expr) - Returns the absolute value of the numeric value",
extended = "> SELECT _FUNC_('-1');\n1")
-case class Abs(child: Expression)
- extends UnaryExpression with ExpectsInputTypes with CodegenFallback {
+case class Abs(child: Expression) extends UnaryExpression with ExpectsInputTypes {
override def inputTypes: Seq[AbstractDataType] = Seq(NumericType)
http://git-wip-us.apache.org/repos/asf/spark/blob/5a2330e5/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
index edfffbc..6db4e19 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
@@ -1139,7 +1139,7 @@ case class RegExpExtract(subject: Expression, regexp: Expression, idx: Expressio
* fractional part.
*/
case class FormatNumber(x: Expression, d: Expression)
- extends BinaryExpression with ExpectsInputTypes with CodegenFallback {
+ extends BinaryExpression with ExpectsInputTypes {
override def left: Expression = x
override def right: Expression = d
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org