[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #4140: [Feature][Zeta][REST-API]add get running job info by jobId

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on code in PR #4140:
URL: https://github.com/apache/incubator-seatunnel/pull/4140#discussion_r1127541941


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/rest/RestHttpGetCommandProcessor.java:
##########
@@ -67,10 +70,19 @@ public RestHttpGetCommandProcessor(
     @Override
     public void handle(HttpGetCommand httpGetCommand) {
         String uri = httpGetCommand.getURI();
-        if (uri.startsWith("/hazelcast/rest/maps/running-jobs")) {
-            handleRunningJobsInfo(httpGetCommand);
-        } else {
-            original.handle(httpGetCommand);
+        try {
+            if (uri.startsWith("/hazelcast/rest/maps/running-jobs")) {

Review Comment:
   Maybe use constant string to manage url path maybe better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org