You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/06 03:19:10 UTC

[GitHub] [iceberg] openinx commented on issue #1152: Why do we need two avro record readers & writers ?

openinx commented on issue #1152:
URL: https://github.com/apache/iceberg/issues/1152#issuecomment-653993749


   @chenjunjiedada , Thanks you for following up on this issue.   `deprecated` the existed `DataWriter` and `DataReader`  looks good to me, I guess we don't need to copy all the codes from `DataWriter` to `AvroGenericWriter` because we can abstract the common logic, for example  putting the common logic in a `BaseAvroWriter` then  the `DataWriter` and `AvroGeneircWriter` will extend from it, similar with the patch https://github.com/apache/iceberg/commit/41cc1334bfe50c7dccb58baeb664b236732f0e2b. After several releases, we could just remove the deprecated `DataWriter` interfaces.  Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org