You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2008/09/15 20:13:44 UTC
[jira] Created: (HADOOP-4174) Move non-client methods ou of
ClientProtocol
Move non-client methods ou of ClientProtocol
--------------------------------------------
Key: HADOOP-4174
URL: https://issues.apache.org/jira/browse/HADOOP-4174
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Affects Versions: 0.17.0
Reporter: Konstantin Shvachko
Assignee: Konstantin Shvachko
Fix For: 0.19.0
3 ClientProtocol methods {{getEditLogSize()}}, {{rollEditLog()}}, {{rollFSImage()}} are never called and should not be by DFSClient.
These methods should be moved into NamenodeProtocol.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4174) Move non-client methods ou of
ClientProtocol
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-4174:
----------------------------------------
Attachment: NNProtocol.patch
Wrong file.
Thanks for the reviews.
> Move non-client methods ou of ClientProtocol
> --------------------------------------------
>
> Key: HADOOP-4174
> URL: https://issues.apache.org/jira/browse/HADOOP-4174
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.19.0
>
> Attachments: NNProtocol.patch, NNProtocol.patch
>
>
> 3 ClientProtocol methods {{getEditLogSize()}}, {{rollEditLog()}}, {{rollFSImage()}} are never called and should not be by DFSClient.
> These methods should be moved into NamenodeProtocol.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4174) Move non-client methods ou of
ClientProtocol
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633307#action_12633307 ]
Hudson commented on HADOOP-4174:
--------------------------------
Integrated in Hadoop-trunk #611 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/611/])
> Move non-client methods ou of ClientProtocol
> --------------------------------------------
>
> Key: HADOOP-4174
> URL: https://issues.apache.org/jira/browse/HADOOP-4174
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.19.0
>
> Attachments: NNProtocol.patch, NNProtocol.patch
>
>
> 3 ClientProtocol methods {{getEditLogSize()}}, {{rollEditLog()}}, {{rollFSImage()}} are never called and should not be by DFSClient.
> These methods should be moved into NamenodeProtocol.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4174) Move non-client methods ou of
ClientProtocol
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-4174:
----------------------------------------
Attachment: NNProtocol.patch
> Move non-client methods ou of ClientProtocol
> --------------------------------------------
>
> Key: HADOOP-4174
> URL: https://issues.apache.org/jira/browse/HADOOP-4174
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.19.0
>
> Attachments: NNProtocol.patch
>
>
> 3 ClientProtocol methods {{getEditLogSize()}}, {{rollEditLog()}}, {{rollFSImage()}} are never called and should not be by DFSClient.
> These methods should be moved into NamenodeProtocol.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4174) Move non-client methods ou of
ClientProtocol
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4174:
-------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks Konstantin.
> Move non-client methods ou of ClientProtocol
> --------------------------------------------
>
> Key: HADOOP-4174
> URL: https://issues.apache.org/jira/browse/HADOOP-4174
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.19.0
>
> Attachments: NNProtocol.patch, NNProtocol.patch
>
>
> 3 ClientProtocol methods {{getEditLogSize()}}, {{rollEditLog()}}, {{rollFSImage()}} are never called and should not be by DFSClient.
> These methods should be moved into NamenodeProtocol.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4174) Move non-client methods ou of
ClientProtocol
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631523#action_12631523 ]
Hadoop QA commented on HADOOP-4174:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12390163/NNProtocol.patch
against trunk revision 695844.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3274/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3274/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3274/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3274/console
This message is automatically generated.
> Move non-client methods ou of ClientProtocol
> --------------------------------------------
>
> Key: HADOOP-4174
> URL: https://issues.apache.org/jira/browse/HADOOP-4174
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.19.0
>
> Attachments: NNProtocol.patch, NNProtocol.patch
>
>
> 3 ClientProtocol methods {{getEditLogSize()}}, {{rollEditLog()}}, {{rollFSImage()}} are never called and should not be by DFSClient.
> These methods should be moved into NamenodeProtocol.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4174) Move non-client methods ou of
ClientProtocol
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-4174:
----------------------------------------
Status: Patch Available (was: Open)
> Move non-client methods ou of ClientProtocol
> --------------------------------------------
>
> Key: HADOOP-4174
> URL: https://issues.apache.org/jira/browse/HADOOP-4174
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.19.0
>
> Attachments: NNProtocol.patch
>
>
> 3 ClientProtocol methods {{getEditLogSize()}}, {{rollEditLog()}}, {{rollFSImage()}} are never called and should not be by DFSClient.
> These methods should be moved into NamenodeProtocol.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4174) Move non-client methods ou of
ClientProtocol
Posted by "Lohit Vijayarenu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631160#action_12631160 ]
Lohit Vijayarenu commented on HADOOP-4174:
------------------------------------------
Konstantin, this looks good. +1.
> Move non-client methods ou of ClientProtocol
> --------------------------------------------
>
> Key: HADOOP-4174
> URL: https://issues.apache.org/jira/browse/HADOOP-4174
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.19.0
>
> Attachments: NNProtocol.patch
>
>
> 3 ClientProtocol methods {{getEditLogSize()}}, {{rollEditLog()}}, {{rollFSImage()}} are never called and should not be by DFSClient.
> These methods should be moved into NamenodeProtocol.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4174) Move non-client methods ou of
ClientProtocol
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4174:
-------------------------------------------
Hadoop Flags: [Reviewed]
+1 for the patch
Need release note.
> Move non-client methods ou of ClientProtocol
> --------------------------------------------
>
> Key: HADOOP-4174
> URL: https://issues.apache.org/jira/browse/HADOOP-4174
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.19.0
>
> Attachments: NNProtocol.patch, NNProtocol.patch
>
>
> 3 ClientProtocol methods {{getEditLogSize()}}, {{rollEditLog()}}, {{rollFSImage()}} are never called and should not be by DFSClient.
> These methods should be moved into NamenodeProtocol.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4174) Move non-client methods ou of
ClientProtocol
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631221#action_12631221 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4174:
------------------------------------------------
NNProtocol.patch:
- These 3 methods are still in ClientProtocol. Are you going to remove them?
- Need to update NamenodeProtocol version.
> Move non-client methods ou of ClientProtocol
> --------------------------------------------
>
> Key: HADOOP-4174
> URL: https://issues.apache.org/jira/browse/HADOOP-4174
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.17.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.19.0
>
> Attachments: NNProtocol.patch
>
>
> 3 ClientProtocol methods {{getEditLogSize()}}, {{rollEditLog()}}, {{rollFSImage()}} are never called and should not be by DFSClient.
> These methods should be moved into NamenodeProtocol.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.