[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #516: [SUREFIRE-2065] Test Reports Inconsistencies with Parameterized and junit4

[GitBox <gi...@apache.org>]

Tibor17 commented on code in PR #516:
URL: https://github.com/apache/maven-surefire/pull/516#discussion_r857087085


##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java:
##########
@@ -312,7 +312,7 @@ private void addTestMethodStats()
         for ( WrappedReportEntry reportEntry : detailsForThis.getReportEntries() )
         {
             TestMethodStats methodStats =
-                new TestMethodStats( reportEntry.getClassMethodName(), reportEntry.getReportEntryType(),
+                new TestMethodStats( reportEntry.getReportClassMethodName(), reportEntry.getReportEntryType(),

Review Comment:
   @chalmagr I do not think this is right because source/name is always extracted from JUnit4 Description which encodes both strings as follows `name(source)` and JUnit ensures that the descrption is unique. Typically, junit encodes `name` as `<method>[<id>]`. If this is wrong, then the problem is in provider and not in this class TSRL.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org