[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3777: ARTEMIS-3502 Auto delete & auto create leading to inconsistencies

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3777:
URL: https://github.com/apache/activemq-artemis/pull/3777#discussion_r717745030



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -1695,18 +1695,18 @@ public ServerSession createSession(final String name,
 
    @Override
    public ServerSession createInternalSession(String name,
-                                       int minLargeMessageSize,

Review comment:
       My own review: remove these changes that are doing nothing...

##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -2111,8 +2111,8 @@ static boolean isAutoDelete(boolean autoCreated, AddressSettings addressSettings
    @Deprecated
    @Override
    public Queue createQueue(SimpleString address, RoutingType routingType, SimpleString queueName, SimpleString filter,
-                     SimpleString user, boolean durable, boolean temporary, boolean ignoreIfExists, boolean transientQueue,
-                     boolean autoCreated, int maxConsumers, boolean purgeOnNoConsumers, boolean autoCreateAddress) throws Exception {
+                            SimpleString user, boolean durable, boolean temporary, boolean ignoreIfExists, boolean transientQueue,

Review comment:
       I will remove this changes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org