You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Christine Poerschke (JIRA)" <ji...@apache.org> on 2016/08/15 10:49:21 UTC
[jira] [Commented] (SOLR-9413) Function result is ignored
[ https://issues.apache.org/jira/browse/SOLR-9413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420836#comment-15420836 ]
Christine Poerschke commented on SOLR-9413:
-------------------------------------------
Perhaps along with the fix in the [lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/util/CSVUtil.java|https://github.com/apache/lucene-solr/blob/master/lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/util/CSVUtil.java] class we could also add a test for the method and/or class?
> Function result is ignored
> --------------------------
>
> Key: SOLR-9413
> URL: https://issues.apache.org/jira/browse/SOLR-9413
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: 6.1
> Reporter: AppChecker
> Priority: Minor
>
> Hello!
> Code in the method [CSVUtil. quoteEscape|https://github.com/apache/lucene-solr/blob/633a89c0376e3db5b8c7efe325cdc3a409e250e5/lucene/analysis/kuromoji/src/java/org/apache/lucene/analysis/ja/util/CSVUtil.java#L104]
> {code:title=CSVUtil.java|borderStyle=solid}
> if (result.indexOf('\"') >= 0) {
> result.replace("\"", ESCAPED_QUOTE);
> }
> {code}
> ignores the return value of the String.replace method.
> Probably, is should be:
> {code:title=CSVUtil.java|borderStyle=solid}
> if (result.indexOf('\"') >= 0) {
> result = result.replace("\"", ESCAPED_QUOTE);
> }
> {code}
> This possible defect found by [static code analyzer AppChecker|http://cnpo.ru/en/solutions/appchecker.php]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org