You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/07/09 09:38:05 UTC

[GitHub] ivankelly commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers

ivankelly commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers
URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r200938995
 
 

 ##########
 File path: tests/integration/s3-offload/src/test/java/org/apache/pulsar/tests/integration/TestS3Offload.java
 ##########
 @@ -59,9 +61,11 @@
     @BeforeMethod
     public void configureAndStartBrokers() throws Exception {
 
-        String s3ip = DockerUtils.cubeIdsWithLabels(
-                docker, ImmutableMap.of("service", "s3", "cluster", CLUSTER_NAME))
-            .stream().map((c) -> DockerUtils.getContainerIP(docker, c)).findFirst().get();
+//        String s3ip = DockerUtils.cubeIdsWithLabels(
 
 Review comment:
   Remove commented out code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services