[GitHub] hqucms opened a new pull request #11493: Fix MXPredReshape in the c_predict_api

[GitBox <gi...@apache.org>]

hqucms opened a new pull request #11493: Fix MXPredReshape in the c_predict_api
URL: https://github.com/apache/incubator-mxnet/pull/11493
 
 
   ## Description ##
   
   This PR fixes the `MXPredReshape` implementation in the c_predict_api. 
   In https://github.com/apache/incubator-mxnet/pull/9984, `aux_arrays`, `sym`, and `ctx` members were introduced in `struct MXAPIPredictor` but not assigned in `MXPredCreatePartialOut`, 
   thus the `PredictorHandle` created by `MXPredCreatePartialOut` cannot be reshaped in `MXPredReshape`.
   This was pointed out in https://github.com/apache/incubator-mxnet/issues/10502, and likely also related to https://github.com/apache/incubator-mxnet/issues/11413, https://github.com/apache/incubator-mxnet/issues/10937.
   
   Also removed the clean-up of the original handle,
   ```
     p->arg_arrays.clear();
     ...
     p->aux_arrays.clear();
   ```
   in `MXPredReshape`, as it makes the original handle invalid. I think it would be better to leave the freedom to the user that whether they want to free the old handle after reshaping, or to free the reshaped new handle after use and revive the old one.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services