You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/07/10 04:05:29 UTC
Review Request 12393: Normalize breadcrumbs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12393/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Breadcrumbs now use single-letter badges to represent Master, Slave, Framework, and Executor. The rightmost crumb is always the current page and shows the non-truncated ID of the resource.
With a lot of long IDs, the breadcrumbs become very long especially on smaller screens. Using the truncated ID and single letters to designate resource types shows all information in less space.
Diffs
-----
src/webui/master/static/browse.html 6a3d29019524584e744075ca1c294ae5c9360d81
src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
Diff: https://reviews.apache.org/r/12393/diff/
Testing
-------
Rendered each page of the site.
File Attachments
----------------
Master breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_master.png
Slave breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_slave.png
Executor breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_executor.png
Thanks,
Ross Allen
Re: Review Request 12393: Normalize breadcrumbs
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12393/#review23103
-----------------------------------------------------------
Ship it!
Looks good! Maybe in another change we can add the framework name and ID in the sidebar of the slave_executor.html page.
- Ben Mahler
On July 12, 2013, 9:33 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12393/
> -----------------------------------------------------------
>
> (Updated July 12, 2013, 9:33 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Breadcrumbs now use single-letter badges to represent Master, Slave, Framework, and Executor. The rightmost crumb is always the current page and shows the non-truncated ID of the resource.
>
> With a lot of long IDs, the breadcrumbs become very long especially on smaller screens. Using the truncated ID and single letters to designate resource types shows all information in less space.
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html 6a3d29019524584e744075ca1c294ae5c9360d81
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
> src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
>
> Diff: https://reviews.apache.org/r/12393/diff/
>
>
> Testing
> -------
>
> Rendered each page of the site.
>
>
> File Attachments
> ----------------
>
> Slave breadcrumb
> https://reviews.apache.org/media/uploaded/files/2013/07/10/slave-breadcrumb.png
> Executor breadcrumb
> https://reviews.apache.org/media/uploaded/files/2013/07/10/executor-breadcrumb.png
> Framework hover breadcrumb
> https://reviews.apache.org/media/uploaded/files/2013/07/10/framework-hover-breadcrumb.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12393: Normalize breadcrumbs
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12393/
-----------------------------------------------------------
(Updated July 12, 2013, 9:33 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Breadcrumbs now use single-letter badges to represent Master, Slave, Framework, and Executor. The rightmost crumb is always the current page and shows the non-truncated ID of the resource.
With a lot of long IDs, the breadcrumbs become very long especially on smaller screens. Using the truncated ID and single letters to designate resource types shows all information in less space.
Diffs (updated)
-----
src/webui/master/static/browse.html 6a3d29019524584e744075ca1c294ae5c9360d81
src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
Diff: https://reviews.apache.org/r/12393/diff/
Testing
-------
Rendered each page of the site.
File Attachments
----------------
Slave breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/slave-breadcrumb.png
Executor breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/executor-breadcrumb.png
Framework hover breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/framework-hover-breadcrumb.png
Thanks,
Ross Allen
Re: Review Request 12393: Normalize breadcrumbs
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12393/
-----------------------------------------------------------
(Updated July 11, 2013, 5:41 p.m.)
Review request for mesos.
Changes
-------
Use full "Master", "Slave", etc. breadcrumbs.
Repository: mesos
Description
-------
Breadcrumbs now use single-letter badges to represent Master, Slave, Framework, and Executor. The rightmost crumb is always the current page and shows the non-truncated ID of the resource.
With a lot of long IDs, the breadcrumbs become very long especially on smaller screens. Using the truncated ID and single letters to designate resource types shows all information in less space.
Diffs (updated)
-----
src/webui/master/static/browse.html 6a3d29019524584e744075ca1c294ae5c9360d81
src/webui/master/static/framework.html 77c6455565379f53f7fb3c4848487fd4dcca4189
src/webui/master/static/frameworks.html 0e2c69190176df0f0d0d74c52d369a0e1a62069b
src/webui/master/static/home.html e98c9756ba99be2283c79226c729d439894f952f
src/webui/master/static/mesos.css 9a5b4e1c619374858e41cd906c02643264f63f72
src/webui/master/static/slave.html 74ede1da3aead3c2ffe3c369b191247a16696be0
src/webui/master/static/slave_executor.html 354832e46ea0ba9155eaed45cfcc6e344c8bae9c
src/webui/master/static/slave_framework.html 74fba640e716ea30497192edcfd91e71c2f365b4
src/webui/master/static/slaves.html 9c73ecf7178fd4e83e9bd4c1325d2cb261770200
Diff: https://reviews.apache.org/r/12393/diff/
Testing
-------
Rendered each page of the site.
File Attachments
----------------
Slave breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/slave-breadcrumb.png
Executor breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/executor-breadcrumb.png
Framework hover breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/framework-hover-breadcrumb.png
Thanks,
Ross Allen
Re: Review Request 12393: Normalize breadcrumbs
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12393/
-----------------------------------------------------------
(Updated July 10, 2013, 11:09 p.m.)
Review request for mesos.
Changes
-------
Update screenshots to show latest breadcrumb styles.
Repository: mesos
Description
-------
Breadcrumbs now use single-letter badges to represent Master, Slave, Framework, and Executor. The rightmost crumb is always the current page and shows the non-truncated ID of the resource.
With a lot of long IDs, the breadcrumbs become very long especially on smaller screens. Using the truncated ID and single letters to designate resource types shows all information in less space.
Diffs
-----
src/webui/master/static/browse.html 6a3d29019524584e744075ca1c294ae5c9360d81
src/webui/master/static/framework.html 77c6455565379f53f7fb3c4848487fd4dcca4189
src/webui/master/static/frameworks.html 0e2c69190176df0f0d0d74c52d369a0e1a62069b
src/webui/master/static/home.html e98c9756ba99be2283c79226c729d439894f952f
src/webui/master/static/mesos.css 9a5b4e1c619374858e41cd906c02643264f63f72
src/webui/master/static/slave.html 74ede1da3aead3c2ffe3c369b191247a16696be0
src/webui/master/static/slave_executor.html 354832e46ea0ba9155eaed45cfcc6e344c8bae9c
src/webui/master/static/slave_framework.html 74fba640e716ea30497192edcfd91e71c2f365b4
src/webui/master/static/slaves.html 9c73ecf7178fd4e83e9bd4c1325d2cb261770200
Diff: https://reviews.apache.org/r/12393/diff/
Testing
-------
Rendered each page of the site.
File Attachments (updated)
----------------
Slave breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/slave-breadcrumb.png
Executor breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/executor-breadcrumb.png
Framework hover breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/framework-hover-breadcrumb.png
Thanks,
Ross Allen
Re: Review Request 12393: Normalize breadcrumbs
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12393/
-----------------------------------------------------------
(Updated July 10, 2013, 11:07 p.m.)
Review request for mesos.
Changes
-------
Use full "Master", "Slave", etc. titles in breadcrumbs and move IDs to 'title' attributes.
Repository: mesos
Description
-------
Breadcrumbs now use single-letter badges to represent Master, Slave, Framework, and Executor. The rightmost crumb is always the current page and shows the non-truncated ID of the resource.
With a lot of long IDs, the breadcrumbs become very long especially on smaller screens. Using the truncated ID and single letters to designate resource types shows all information in less space.
Diffs (updated)
-----
src/webui/master/static/browse.html 6a3d29019524584e744075ca1c294ae5c9360d81
src/webui/master/static/framework.html 77c6455565379f53f7fb3c4848487fd4dcca4189
src/webui/master/static/frameworks.html 0e2c69190176df0f0d0d74c52d369a0e1a62069b
src/webui/master/static/home.html e98c9756ba99be2283c79226c729d439894f952f
src/webui/master/static/mesos.css 9a5b4e1c619374858e41cd906c02643264f63f72
src/webui/master/static/slave.html 74ede1da3aead3c2ffe3c369b191247a16696be0
src/webui/master/static/slave_executor.html 354832e46ea0ba9155eaed45cfcc6e344c8bae9c
src/webui/master/static/slave_framework.html 74fba640e716ea30497192edcfd91e71c2f365b4
src/webui/master/static/slaves.html 9c73ecf7178fd4e83e9bd4c1325d2cb261770200
Diff: https://reviews.apache.org/r/12393/diff/
Testing
-------
Rendered each page of the site.
File Attachments
----------------
Master breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_master.png
Slave breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_slave.png
Executor breadcrumb
https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_executor.png
Thanks,
Ross Allen
Re: Review Request 12393: Normalize breadcrumbs
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 10, 2013, 8:34 p.m., Ben Mahler wrote:
> > Love it! My only comment would be that the single letter badges might not be too obvious to users who do not know what 'M', 'S', 'F', and 'E' stand for. Could you use the full words, does that still save space?
> >
> > What if we hid the ID altogether? Perhaps showing it on hover or copying it? I'm not sure showing the IDs (of the master / slave / framework) are that useful in the breadcrumbs. Thoughts?
>
> Ross Allen wrote:
> Maybe this commit is not worth the change then? I can instead just replace the IDs in the current breadcrumbs with "Slave", "Framework", "Executor", etc.
The diffs don't seem to be loading, but let me know what you think of the screenshots if you can't see the diff.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12393/#review22970
-----------------------------------------------------------
On July 10, 2013, 11:09 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12393/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 11:09 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Breadcrumbs now use single-letter badges to represent Master, Slave, Framework, and Executor. The rightmost crumb is always the current page and shows the non-truncated ID of the resource.
>
> With a lot of long IDs, the breadcrumbs become very long especially on smaller screens. Using the truncated ID and single letters to designate resource types shows all information in less space.
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html 6a3d29019524584e744075ca1c294ae5c9360d81
> src/webui/master/static/framework.html 77c6455565379f53f7fb3c4848487fd4dcca4189
> src/webui/master/static/frameworks.html 0e2c69190176df0f0d0d74c52d369a0e1a62069b
> src/webui/master/static/home.html e98c9756ba99be2283c79226c729d439894f952f
> src/webui/master/static/mesos.css 9a5b4e1c619374858e41cd906c02643264f63f72
> src/webui/master/static/slave.html 74ede1da3aead3c2ffe3c369b191247a16696be0
> src/webui/master/static/slave_executor.html 354832e46ea0ba9155eaed45cfcc6e344c8bae9c
> src/webui/master/static/slave_framework.html 74fba640e716ea30497192edcfd91e71c2f365b4
> src/webui/master/static/slaves.html 9c73ecf7178fd4e83e9bd4c1325d2cb261770200
>
> Diff: https://reviews.apache.org/r/12393/diff/
>
>
> Testing
> -------
>
> Rendered each page of the site.
>
>
> File Attachments
> ----------------
>
> Slave breadcrumb
> https://reviews.apache.org/media/uploaded/files/2013/07/10/slave-breadcrumb.png
> Executor breadcrumb
> https://reviews.apache.org/media/uploaded/files/2013/07/10/executor-breadcrumb.png
> Framework hover breadcrumb
> https://reviews.apache.org/media/uploaded/files/2013/07/10/framework-hover-breadcrumb.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12393: Normalize breadcrumbs
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 10, 2013, 8:34 p.m., Ben Mahler wrote:
> > Love it! My only comment would be that the single letter badges might not be too obvious to users who do not know what 'M', 'S', 'F', and 'E' stand for. Could you use the full words, does that still save space?
> >
> > What if we hid the ID altogether? Perhaps showing it on hover or copying it? I'm not sure showing the IDs (of the master / slave / framework) are that useful in the breadcrumbs. Thoughts?
Maybe this commit is not worth the change then? I can instead just replace the IDs in the current breadcrumbs with "Slave", "Framework", "Executor", etc.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12393/#review22970
-----------------------------------------------------------
On July 10, 2013, 2:05 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12393/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 2:05 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Breadcrumbs now use single-letter badges to represent Master, Slave, Framework, and Executor. The rightmost crumb is always the current page and shows the non-truncated ID of the resource.
>
> With a lot of long IDs, the breadcrumbs become very long especially on smaller screens. Using the truncated ID and single letters to designate resource types shows all information in less space.
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html 6a3d29019524584e744075ca1c294ae5c9360d81
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
> src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
>
> Diff: https://reviews.apache.org/r/12393/diff/
>
>
> Testing
> -------
>
> Rendered each page of the site.
>
>
> File Attachments
> ----------------
>
> Master breadcrumb
> https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_master.png
> Slave breadcrumb
> https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_slave.png
> Executor breadcrumb
> https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_executor.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12393: Normalize breadcrumbs
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12393/#review22970
-----------------------------------------------------------
Love it! My only comment would be that the single letter badges might not be too obvious to users who do not know what 'M', 'S', 'F', and 'E' stand for. Could you use the full words, does that still save space?
What if we hid the ID altogether? Perhaps showing it on hover or copying it? I'm not sure showing the IDs (of the master / slave / framework) are that useful in the breadcrumbs. Thoughts?
- Ben Mahler
On July 10, 2013, 2:05 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12393/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 2:05 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Breadcrumbs now use single-letter badges to represent Master, Slave, Framework, and Executor. The rightmost crumb is always the current page and shows the non-truncated ID of the resource.
>
> With a lot of long IDs, the breadcrumbs become very long especially on smaller screens. Using the truncated ID and single letters to designate resource types shows all information in less space.
>
>
> Diffs
> -----
>
> src/webui/master/static/browse.html 6a3d29019524584e744075ca1c294ae5c9360d81
> src/webui/master/static/framework.html c3827e886351308dadd61fbe6a7570ad5d3d5110
> src/webui/master/static/frameworks.html acb0eaa3ca8e893c92f4cfe887760d8a6f3ad182
> src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1
> src/webui/master/static/mesos.css 255219f09b1ec9cecd96bf4517c7e184264810b5
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
> src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
> src/webui/master/static/slaves.html 508748f16c87a1ad2f3f9f4af33767165b61052c
>
> Diff: https://reviews.apache.org/r/12393/diff/
>
>
> Testing
> -------
>
> Rendered each page of the site.
>
>
> File Attachments
> ----------------
>
> Master breadcrumb
> https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_master.png
> Slave breadcrumb
> https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_slave.png
> Executor breadcrumb
> https://reviews.apache.org/media/uploaded/files/2013/07/10/breadcrumb_executor.png
>
>
> Thanks,
>
> Ross Allen
>
>