You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Ryan Holmes <ry...@hyperstep.com> on 2006/11/19 11:26:48 UTC

Re: If problem with latest 4.1 head

Just now had time to get back to this -- here is a patch to add the  
renderTag parameter to ForBean. Updated docs and tests are included.  
If attachments don't work over the list I'll create an issue and  
attach the patch there.

One minor issue -- I think the logic in IfBean and ElseBean that sets  
the render flag is incorrect with regard to the 'element' parameter.  
The current logic is:

boolean render = !cycleRewinding && getRenderTag();

I think the presence of an element parameter should force the render,  
regardless of the value of renderTag. Here's what I put in ForBean:

boolean render = !cycleRewinding && (getRenderTag() ||  
HiveMind.isNonBlank(getElement()));

I don't like the extra condition, but without it upgraders could be  
in for a jarring experience (especially if they turn renderTags off  
with the config property).