You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2008/09/14 00:38:44 UTC

svn commit: r695050 - /myfaces/core/trunk_1.2.x/impl/src/main/java/org/apache/myfaces/taglib/core/GenericListenerTag.java

Author: lu4242
Date: Sat Sep 13 15:38:43 2008
New Revision: 695050

URL: http://svn.apache.org/viewvc?rev=695050&view=rev
Log:
MYFACES-1964 JspException thrown if actionListener's type attribute is not supplied (thanks to Paul Rivera)

Modified:
    myfaces/core/trunk_1.2.x/impl/src/main/java/org/apache/myfaces/taglib/core/GenericListenerTag.java

Modified: myfaces/core/trunk_1.2.x/impl/src/main/java/org/apache/myfaces/taglib/core/GenericListenerTag.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk_1.2.x/impl/src/main/java/org/apache/myfaces/taglib/core/GenericListenerTag.java?rev=695050&r1=695049&r2=695050&view=diff
==============================================================================
--- myfaces/core/trunk_1.2.x/impl/src/main/java/org/apache/myfaces/taglib/core/GenericListenerTag.java (original)
+++ myfaces/core/trunk_1.2.x/impl/src/main/java/org/apache/myfaces/taglib/core/GenericListenerTag.java Sat Sep 13 15:38:43 2008
@@ -78,9 +78,9 @@
             throw new JspException("no parent UIComponentTag found");
         }
 
-        if (_type == null)
+        if (_type == null && _binding == null)
         {
-            throw new JspException("type attribute not set");
+            throw new JspException("\"actionListener\" must have binding and/or type attribute.");
         }
 
         if (!componentTag.getCreated())
@@ -88,11 +88,6 @@
             return Tag.SKIP_BODY;
         }
 
-        if (_type == null)
-        {
-            throw new JspException("type attribute not set");
-        }
-
         _Holder holder = null;
         UIComponent component = componentTag.getComponentInstance();
         try