You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/07 10:46:11 UTC

[GitHub] [spark] cloud-fan opened a new pull request #24546: [SPARK-27650][SQL] sepate the row iterator functionality from ColumnarBatch

cloud-fan opened a new pull request #24546: [SPARK-27650][SQL] sepate the row iterator functionality from ColumnarBatch
URL: https://github.com/apache/spark/pull/24546
 
 
   ## What changes were proposed in this pull request?
   
   `ColumnarBatch` is user-facing, we should expose as fewer details as possible.
   
   `ColumnarBatch` is used to carry the data from data source to Spark. Accessing the data in a row-wise style is not its responsibility.
   
   This PR creates `ColumnarBatchRowView`, and moves the row iterator functionality from `ColumnarBatch` to `ColumnarBatchRowView`.
   
   This PR avoids referring to internal classes(MutableColumnarRow) in `ColumnarBatch`, so that we can move DS v2 APIs to catalyst module later in https://github.com/apache/spark/pull/24416
   
   ## How was this patch tested?
   
   existing tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org