You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Christoph Leiter (JIRA)" <ji...@apache.org> on 2012/08/27 10:06:07 UTC
[jira] [Created] (WICKET-4732) CssPackageResource doesn't work if
the extension isn't css
Christoph Leiter created WICKET-4732:
----------------------------------------
Summary: CssPackageResource doesn't work if the extension isn't css
Key: WICKET-4732
URL: https://issues.apache.org/jira/browse/WICKET-4732
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5.8
Reporter: Christoph Leiter
CssPackageResource#processResponse is never called if the extension isn't css. It works for .css because PackageResourceReference#getResource checks if the extension is css and then creates a CssPackageResource. For anything else than .css/.js a PackageResource is created.
Actually the overridden processResponse method in CssPackageResource (instead of PackageResource) should get called, but ResourceReferenceRegistry#createDefaultResourceReference installs a plain PackageResource which gets called later.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4732) CssPackageResource doesn't work if
the extension isn't css
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4732.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5.9
6.0.1
Assignee: Martin Grigorov
Fixed + test.
> CssPackageResource doesn't work if the extension isn't css
> ----------------------------------------------------------
>
> Key: WICKET-4732
> URL: https://issues.apache.org/jira/browse/WICKET-4732
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.8
> Reporter: Christoph Leiter
> Assignee: Martin Grigorov
> Fix For: 6.0.1, 1.5.9
>
> Attachments: wicket-4732.tgz, wicket-4732.zip
>
>
> CssPackageResource#processResponse is never called if the extension isn't css. It works for .css because PackageResourceReference#getResource checks if the extension is css and then creates a CssPackageResource. For anything else than .css/.js a PackageResource is created.
> Actually the overridden processResponse method in CssPackageResource (instead of PackageResource) should get called, but ResourceReferenceRegistry#createDefaultResourceReference installs a plain PackageResource which gets called later.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4732) CssPackageResource doesn't work if
the extension isn't css
Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij updated WICKET-4732:
------------------------------------
Fix Version/s: (was: 6.0.1)
6.1.0
> CssPackageResource doesn't work if the extension isn't css
> ----------------------------------------------------------
>
> Key: WICKET-4732
> URL: https://issues.apache.org/jira/browse/WICKET-4732
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.8
> Reporter: Christoph Leiter
> Assignee: Martin Grigorov
> Fix For: 6.1.0, 1.5.9
>
> Attachments: wicket-4732.tgz, wicket-4732.zip
>
>
> CssPackageResource#processResponse is never called if the extension isn't css. It works for .css because PackageResourceReference#getResource checks if the extension is css and then creates a CssPackageResource. For anything else than .css/.js a PackageResource is created.
> Actually the overridden processResponse method in CssPackageResource (instead of PackageResource) should get called, but ResourceReferenceRegistry#createDefaultResourceReference installs a plain PackageResource which gets called later.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4732) CssPackageResource doesn't work if
the extension isn't css
Posted by "Christoph Leiter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christoph Leiter updated WICKET-4732:
-------------------------------------
Attachment: wicket-4732.zip
Attaching quickstart for 1.5.8. The HomePage renders main.css and main.less. The installed ICssCompressor is only called for main.css but should be called for both.
> CssPackageResource doesn't work if the extension isn't css
> ----------------------------------------------------------
>
> Key: WICKET-4732
> URL: https://issues.apache.org/jira/browse/WICKET-4732
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.8
> Reporter: Christoph Leiter
> Attachments: wicket-4732.tgz, wicket-4732.zip
>
>
> CssPackageResource#processResponse is never called if the extension isn't css. It works for .css because PackageResourceReference#getResource checks if the extension is css and then creates a CssPackageResource. For anything else than .css/.js a PackageResource is created.
> Actually the overridden processResponse method in CssPackageResource (instead of PackageResource) should get called, but ResourceReferenceRegistry#createDefaultResourceReference installs a plain PackageResource which gets called later.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4732) CssPackageResource doesn't work if
the extension isn't css
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4732:
------------------------------------
Attachment: wicket-4732.tgz
Here is a quickstart with 6.0 that works.
> CssPackageResource doesn't work if the extension isn't css
> ----------------------------------------------------------
>
> Key: WICKET-4732
> URL: https://issues.apache.org/jira/browse/WICKET-4732
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.8
> Reporter: Christoph Leiter
> Attachments: wicket-4732.tgz
>
>
> CssPackageResource#processResponse is never called if the extension isn't css. It works for .css because PackageResourceReference#getResource checks if the extension is css and then creates a CssPackageResource. For anything else than .css/.js a PackageResource is created.
> Actually the overridden processResponse method in CssPackageResource (instead of PackageResource) should get called, but ResourceReferenceRegistry#createDefaultResourceReference installs a plain PackageResource which gets called later.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4732) CssPackageResource doesn't work if
the extension isn't css
Posted by "Christoph Leiter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443893#comment-13443893 ]
Christoph Leiter commented on WICKET-4732:
------------------------------------------
Use this in the Wicket 6 quickstart:
public class LessPackageResource extends CssPackageResource {
public LessPackageResource(Class<?> scope, String name) {
super(scope, name, null, null, null);
}
@Override
protected byte[] processResponse(Attributes attributes, byte[] bytes) {
System.err.println("CALLED");
return super.processResponse(attributes, bytes);
}
}
processResponse is also never called there.
> CssPackageResource doesn't work if the extension isn't css
> ----------------------------------------------------------
>
> Key: WICKET-4732
> URL: https://issues.apache.org/jira/browse/WICKET-4732
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.8
> Reporter: Christoph Leiter
> Attachments: wicket-4732.tgz, wicket-4732.zip
>
>
> CssPackageResource#processResponse is never called if the extension isn't css. It works for .css because PackageResourceReference#getResource checks if the extension is css and then creates a CssPackageResource. For anything else than .css/.js a PackageResource is created.
> Actually the overridden processResponse method in CssPackageResource (instead of PackageResource) should get called, but ResourceReferenceRegistry#createDefaultResourceReference installs a plain PackageResource which gets called later.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira