You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Adrian Crum <ad...@hlmksw.com> on 2010/12/21 16:49:04 UTC
Re: svn commit: r1051450 - /ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy
The TimeZone and Locale objects should be in the Groovy context. There
is no need to call the utility methods.
-Adrian
On 12/21/2010 3:08 AM, ashish@apache.org wrote:
> Author: ashish
> Date: Tue Dec 21 11:08:56 2010
> New Revision: 1051450
>
> URL: http://svn.apache.org/viewvc?rev=1051450&view=rev
> Log:
> Bug fix.
> Anyone working in different time zone(lets say PST) should get issue in updating the record.
>
> Modified:
> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy
>
> Modified: ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy?rev=1051450&r1=1051449&r2=1051450&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy (original)
> +++ ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy Tue Dec 21 11:08:56 2010
> @@ -49,7 +49,7 @@ fromDateStr = parameters.FROM_DATE;
>
> fromDate = null;
> if (UtilValidate.isNotEmpty(fromDateStr)) {
> - fromDate = Timestamp.valueOf(fromDateStr);
> + fromDate = ObjectType.simpleTypeConvert(fromDateStr, "Timestamp", null, UtilHttp.getTimeZone(request), UtilHttp.getLocale(request), false);
> }
> if (!fromDate) {
> fromDate = request.getAttribute("ProductAssocCreateFromDate");
>
>
>
Re: svn commit: r1051450 - /ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy
Posted by Ashish Vijaywargiya <vi...@gmail.com>.
This is done.
--
Ashish
On Tue, Dec 21, 2010 at 10:06 PM, Ashish Vijaywargiya <
ashish.vijaywargiya@hotwaxmedia.com> wrote:
> I agree. I will take care of it by tomorrow. Thanks Adrian!
>
> --
> Ashish
>
> ----- "Adrian Crum" <ad...@hlmksw.com> wrote:
>
> > The TimeZone and Locale objects should be in the Groovy context. There
> >
> > is no need to call the utility methods.
> >
> > -Adrian
> >
> > On 12/21/2010 3:08 AM, ashish@apache.org wrote:
> > > Author: ashish
> > > Date: Tue Dec 21 11:08:56 2010
> > > New Revision: 1051450
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1051450&view=rev
> > > Log:
> > > Bug fix.
> > > Anyone working in different time zone(lets say PST) should get issue
> > in updating the record.
> > >
> > > Modified:
> > >
> >
> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy
> > >
> > > Modified:
> >
> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy
> > > URL:
> >
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy?rev=1051450&r1=1051449&r2=1051450&view=diff
> > >
> >
> ==============================================================================
> > > ---
> >
> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy
> > (original)
> > > +++
> >
> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy
> > Tue Dec 21 11:08:56 2010
> > > @@ -49,7 +49,7 @@ fromDateStr = parameters.FROM_DATE;
> > >
> > > fromDate = null;
> > > if (UtilValidate.isNotEmpty(fromDateStr)) {
> > > - fromDate = Timestamp.valueOf(fromDateStr);
> > > + fromDate = ObjectType.simpleTypeConvert(fromDateStr,
> > "Timestamp", null, UtilHttp.getTimeZone(request),
> > UtilHttp.getLocale(request), false);
> > > }
> > > if (!fromDate) {
> > > fromDate =
> > request.getAttribute("ProductAssocCreateFromDate");
> > >
> > >
> > >
>
Re: svn commit: r1051450 -
/ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy
Posted by Ashish Vijaywargiya <as...@hotwaxmedia.com>.
I agree. I will take care of it by tomorrow. Thanks Adrian!
--
Ashish
----- "Adrian Crum" <ad...@hlmksw.com> wrote:
> The TimeZone and Locale objects should be in the Groovy context. There
>
> is no need to call the utility methods.
>
> -Adrian
>
> On 12/21/2010 3:08 AM, ashish@apache.org wrote:
> > Author: ashish
> > Date: Tue Dec 21 11:08:56 2010
> > New Revision: 1051450
> >
> > URL: http://svn.apache.org/viewvc?rev=1051450&view=rev
> > Log:
> > Bug fix.
> > Anyone working in different time zone(lets say PST) should get issue
> in updating the record.
> >
> > Modified:
> >
> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy
> >
> > Modified:
> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy
> > URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy?rev=1051450&r1=1051449&r2=1051450&view=diff
> >
> ==============================================================================
> > ---
> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy
> (original)
> > +++
> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/product/EditProductAssoc.groovy
> Tue Dec 21 11:08:56 2010
> > @@ -49,7 +49,7 @@ fromDateStr = parameters.FROM_DATE;
> >
> > fromDate = null;
> > if (UtilValidate.isNotEmpty(fromDateStr)) {
> > - fromDate = Timestamp.valueOf(fromDateStr);
> > + fromDate = ObjectType.simpleTypeConvert(fromDateStr,
> "Timestamp", null, UtilHttp.getTimeZone(request),
> UtilHttp.getLocale(request), false);
> > }
> > if (!fromDate) {
> > fromDate =
> request.getAttribute("ProductAssocCreateFromDate");
> >
> >
> >