You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/05/24 09:23:45 UTC

[GitHub] [trafficserver] jbfavre opened a new pull request, #8861: Add missing configuration files man pages

jbfavre opened a new pull request, #8861:
URL: https://github.com/apache/trafficserver/pull/8861

   Add missing sni.yaml and strategies.yaml man pages.
   
   Previous list for `appendices/command-line` was sorted per man sections.
   But, IMHO, having it sorted by file name makes list update easier.
   I also tried to improve file readability in avoiding too long lines.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bneradt merged pull request #8861: Add missing configuration files man pages

Posted by GitBox <gi...@apache.org>.
bneradt merged PR #8861:
URL: https://github.com/apache/trafficserver/pull/8861


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] bneradt commented on pull request #8861: Add missing configuration files man pages

Posted by GitBox <gi...@apache.org>.
bneradt commented on PR #8861:
URL: https://github.com/apache/trafficserver/pull/8861#issuecomment-1136484683

   Looks like the autopep8 command fails:
   https://ci.trafficserver.apache.org/job/Github_Builds/job/clang-format/1094/console
   
   ```
   Running autopep8. This may take a minute.
   autopep8 completed.
   + '[' 0 '!=' 0 ']'
   + git diff --exit-code
   diff --git a/doc/manpages.py b/doc/manpages.py
   index 905cc0358..84ebba95e 100644
   --- a/doc/manpages.py
   +++ b/doc/manpages.py
   @@ -22,8 +22,8 @@ man_pages = [
        ('developer-guide/api/functions/' + filename[:-4],
            filename.split('.', 1)[0],
            filename.split('.', 1)[0] + ' API function', None, '3ts')
   -        for filename in os.listdir('developer-guide/api/functions/')
   -        if filename != 'index.en.rst' and filename.endswith('.rst')] + [
   +    for filename in os.listdir('developer-guide/api/functions/')
   +    if filename != 'index.en.rst' and filename.endswith('.rst')] + [
    
        # Add all files in the appendices/command-line directory to the list
        # of manual pages
   + '[' 0 '!=' 1 ']'
   + exit 1
   ```
   
   We should be able to fix this by running the `make autopep8` target in the build tree.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] zwoop commented on pull request #8861: Add missing configuration files man pages

Posted by GitBox <gi...@apache.org>.
zwoop commented on PR #8861:
URL: https://github.com/apache/trafficserver/pull/8861#issuecomment-1137853404

   Cherry-picked to v9.2.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org