You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2020/06/17 15:05:08 UTC
[GitHub] [cxf-fediz] amergey commented on a change in pull request #57: Add support for RSA_SHA256 signature with SAMLProtocol
amergey commented on a change in pull request #57:
URL: https://github.com/apache/cxf-fediz/pull/57#discussion_r441617301
##########
File path: plugins/core/src/main/java/org/apache/cxf/fediz/core/config/SAMLProtocol.java
##########
@@ -53,11 +53,23 @@ protected void setSAMLProtocol(SamlProtocolType samlProtocol) {
}
public boolean isSignRequest() {
- return getSAMLProtocol().isSignRequest();
+ if (getSAMLProtocol().getSignRequest() != null) {
+ return getSAMLProtocol().getSignRequest().isValue();
+ } else {
+ return false;
+ }
+ }
+
+ public SignAlgorithm getSignRequestAlgorithm() {
Review comment:
I have also renamed enum values
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org