[jira] [Commented] (FLINK-25171) When the DDL statement was executed, the column names of the Derived Columns were not validated

["shouzuo meng (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-25171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474266#comment-17474266 ] 

shouzuo meng commented on FLINK-25171:
--------------------------------------

[~godfreyhe] Hi，the solution to this problem has been provided, please spare some time to do the final check

> When the DDL statement was executed, the column names of the Derived Columns were not validated
> -----------------------------------------------------------------------------------------------
>
>                 Key: FLINK-25171
>                 URL: https://issues.apache.org/jira/browse/FLINK-25171
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>    Affects Versions: 1.14.0
>            Reporter: shouzuo meng
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.14.0
>
>         Attachments: 5261638775663_.pic.jpg
>
>
> When I execute the DDL statement, I mistakenly use the duplicate field name in THE SQL, but the execution result of the program does not throw any exception or prompt. In MergeTableLikeUtilTest. Java# mergePhysicalColumns add repeated the TableColumn (), also do not throw any exceptions, review the code logic found only on the source table schema fields, It is not a duplicate and derived tables and fields of the source table is verified, and no field of derived tables if repeated verification, adding physicalFieldNamesToTypes, there will be a repeating field coverage,The following are the execution statements and the results
> DDL sql：
> CREATE TABLE test1 (
>   `log_version` string COMMENT '日志版本',
>   `log_version` INTEGER COMMENT '日志版本',
>   `pv_time` string COMMENT '日志时间'
> ) with(
>         'connector' = 'kafka',
>         'topic' = 'xxx',
>         'properties.bootstrap.servers' = 'xxx:9110',
>         'scan.startup.mode'='latest-offset',
>         'format' = 'json',
> )
> {code:java}
> StreamTableEnvironment tEnv = StreamTableEnvironment.create(env);
> TableResult result = tEnv.executeSql(
> CREATE TABLE test1 (
>   `log_version` string COMMENT '日志版本',
>   `log_version` INTEGER COMMENT '日志版本',
>   `pv_time` string COMMENT '日志时间'
> ) with(
>         'connector' = 'kafka',
>         'topic' = 'xxx',
>         'properties.bootstrap.servers' = 'xxx:9110',
>         'scan.startup.mode'='latest-offset',
>         'format' = 'json',
> )
> ) 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)