You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/06/10 08:07:22 UTC
[GitHub] [incubator-tubemq] hystericalhell opened a new pull request #149: [TUBEMQ-233] Performance Improvement on FileSegmentList
hystericalhell opened a new pull request #149:
URL: https://github.com/apache/incubator-tubemq/pull/149
**Still Prototype** for review first.
Implement segmentList2 replacing native compact array segmentList by using RoundQueue, which brings the flexibility on element modification, and making use of weak CAS to better adapt multi-threaded runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] Technoboy- commented on pull request #149: [TUBEMQ-233] Performance Improvement on FileSegmentList
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #149:
URL: https://github.com/apache/incubator-tubemq/pull/149#issuecomment-641858596
It's better not to involve the new dependency - hppc, for it's not maintained for a long time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang closed pull request #149: [TUBEMQ-233] Performance Improvement on FileSegmentList
Posted by GitBox <gi...@apache.org>.
gosonzhang closed pull request #149:
URL: https://github.com/apache/incubator-tubemq/pull/149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang commented on pull request #149: [TUBEMQ-233] Performance Improvement on FileSegmentList
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on pull request #149:
URL: https://github.com/apache/incubator-tubemq/pull/149#issuecomment-643885585
I suggest not to merge this PR
This change uses the ObjectArrayDeque class to pre-allocate array elements, and uses AtomicBoolean's weakCompareAndSet method to modify and delete the segmentList2 object to be preempted. Compared with before modification: ObjectArrayDeque implementation can improve the performance of new and delete operations; using AtomicBoolean to solve the multi-thread preemption phase, I personally think that there should not be much improvement, the use of AtomicReference should be more perfect.
Personally, from the overall point of view of the system, the performance loss formed by this point is not particularly large, ant it has experienced several years of online operation scenarios and has been relatively stable; the new changes will affect the overall, and the improvement of performance is temporarily unknown, so it is a better choice to temporarily not merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang commented on pull request #149: [TUBEMQ-233] Performance Improvement on FileSegmentList
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on pull request #149:
URL: https://github.com/apache/incubator-tubemq/pull/149#issuecomment-762160700
I'll close this pr, thanks @hystericalhell
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] codecov-commenter commented on pull request #149: [TUBEMQ-233] Performance Improvement on FileSegmentList
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #149:
URL: https://github.com/apache/incubator-tubemq/pull/149#issuecomment-643865635
# [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/149?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@b2ddb28`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tubemq/pull/149?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #149 +/- ##
========================================
Coverage ? 7.60%
Complexity ? 437
========================================
Files ? 235
Lines ? 26521
Branches ? 4413
========================================
Hits ? 2018
Misses ? 24056
Partials ? 447
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/149?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/149?src=pr&el=footer). Last update [b2ddb28...f4ab76b](https://codecov.io/gh/apache/incubator-tubemq/pull/149?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] hystericalhell commented on pull request #149: [TUBEMQ-233] Performance Improvement on FileSegmentList
Posted by GitBox <gi...@apache.org>.
hystericalhell commented on pull request #149:
URL: https://github.com/apache/incubator-tubemq/pull/149#issuecomment-641865190
> It's better not to involve the new dependency - hppc, for it's not maintained for a long time.
Hi Technoboy,
As shown on Maven's repo, the latest hppc 0.8.2 is updated in Jun 2020, and it shows the recent update is just 9 days ago, do you have any formal announcement about they *give up* this project, or any proof about it's out-of-maintenance?
Maven Repo: [HPPC](https://mvnrepository.com/artifact/com.carrotsearch/hppc)
GitHub: [HPPC](https://github.com/carrotsearch/hppc)
Moreover, if you have any better alternative than HPPC, it would be very welcomed, please advise.
Best regards,
Gabriel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] Technoboy- commented on pull request #149: [TUBEMQ-233] Performance Improvement on FileSegmentList
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on pull request #149:
URL: https://github.com/apache/incubator-tubemq/pull/149#issuecomment-641876365
> > It's better not to involve the new dependency - hppc, for it's not maintained for a long time.
>
> Hi Technoboy,
>
> As shown on Maven's repo, the latest hppc 0.8.2 is updated in Jun 2020, and it shows the recent update is just 9 days ago, do you have any formal announcement about they _give up_ this project, or any proof about it's out-of-maintenance?
> Maven Repo: [HPPC](https://mvnrepository.com/artifact/com.carrotsearch/hppc)
> GitHub: [HPPC](https://github.com/carrotsearch/hppc)
>
> Moreover, if you have any better alternative than HPPC, it would be very welcomed, please advise.
>
> Best regards,
> Gabriel
Yes, I re-checked it .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org