You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2011/05/02 18:38:03 UTC

[jira] [Created] (LUCENE-3063) factor CharTokenizer/CharacterUtils into analyzers module

factor CharTokenizer/CharacterUtils into analyzers module
---------------------------------------------------------

                 Key: LUCENE-3063
                 URL: https://issues.apache.org/jira/browse/LUCENE-3063
             Project: Lucene - Java
          Issue Type: Task
            Reporter: Robert Muir
             Fix For: 4.0
         Attachments: LUCENE-3063.patch

Currently these analysis components are in the lucene core, but should really
be .util in the analyzers module.

Also, with MockTokenizer extending Tokenizer directly, we can add some additional
checks in the future to try to ensure our consumers are being good consumers (e.g. calling reset).

This is mentioned in http://wiki.apache.org/lucene-java/TestIdeas, I didn't implement it here yet,
this is just the factoring. I think we should try to do this before LUCENE-3040.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3063) factor CharTokenizer/CharacterUtils into analyzers module

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3063:
--------------------------------

    Attachment: LUCENE-3063.patch

> factor CharTokenizer/CharacterUtils into analyzers module
> ---------------------------------------------------------
>
>                 Key: LUCENE-3063
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3063
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3063.patch
>
>
> Currently these analysis components are in the lucene core, but should really
> be .util in the analyzers module.
> Also, with MockTokenizer extending Tokenizer directly, we can add some additional
> checks in the future to try to ensure our consumers are being good consumers (e.g. calling reset).
> This is mentioned in http://wiki.apache.org/lucene-java/TestIdeas, I didn't implement it here yet,
> this is just the factoring. I think we should try to do this before LUCENE-3040.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Issue Comment Edited] (LUCENE-3063) factor CharTokenizer/CharacterUtils into analyzers module

Posted by "Neil Hooey (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143533#comment-13143533 ] 

Neil Hooey edited comment on LUCENE-3063 at 11/3/11 9:13 PM:
-------------------------------------------------------------

Now that CharTokenizer has been moved in to the analyzer module, the binary build has the CharTokenizer.class inside a jar file that's inside a war file.

It doesn't seem like you can build a Lucene or Solr plugin without manually extracting the jar in the war.

In the particular Solr binary distribution:
apache-solr-4.0-2011-11-03_08-39-12

The CharTokenizer.class file is here:
dist/apache-solr-4.0-2011-11-03_08-39-12.war/WEB-INF/lib/lucene-analyzers-common-4.0-2011-11-03_08-39-12.jar/org/apache/lucene/analysis/util/CharTokenizer.class

Is there any way to use Ant to build a plugin that uses CharTokenizer without first extracting the war file?

If not, could you consider having the lucene-analyzers-common-4.0-2011-11-03_08-39-12.jar file just in a directory instead of inside a war file?
                
      was (Author: nhooey):
    Now that CharTokenizer has been moved in to the analyzer module, the binary build has the CharTokenizer.class inside a jar file that's inside a war file.

It doesn't seem like you can build a Lucene or Solr plugin without manually extracting the jar in the war.

In the particular Solr binary distribution:
apache-solr-4.0-2011-11-03_08-39-12

The CharTokenizer.class file is here:
dist/apache-solr-4.0-2011-11-03_08-39-12.war/WEB-INF/lib/lucene-analyzers-common-4.0-2011-11-03_08-39-12.jar/org/apache/lucene/analysis/util/CharTokenizer.class

Is there any way to use Ant to build a plugin that uses CharTokenizer without first extracting the war file?

If not, could you consider having the lucene-analyzers-common-4.0-2011-11-03_08-39-12.jar file just in a directory in the binary distribution?
                  
> factor CharTokenizer/CharacterUtils into analyzers module
> ---------------------------------------------------------
>
>                 Key: LUCENE-3063
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3063
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3063.patch
>
>
> Currently these analysis components are in the lucene core, but should really
> be .util in the analyzers module.
> Also, with MockTokenizer extending Tokenizer directly, we can add some additional
> checks in the future to try to ensure our consumers are being good consumers (e.g. calling reset).
> This is mentioned in http://wiki.apache.org/lucene-java/TestIdeas, I didn't implement it here yet,
> this is just the factoring. I think we should try to do this before LUCENE-3040.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3063) factor CharTokenizer/CharacterUtils into analyzers module

Posted by "Neil Hooey (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143533#comment-13143533 ] 

Neil Hooey commented on LUCENE-3063:
------------------------------------

Now that CharTokenizer has been moved in to the analyzer module, the binary build has the CharTokenizer.class inside a jar file that's inside a war file.

It doesn't seem like you can build a Lucene or Solr plugin without manually extracting the jar in the war.

In the particular Solr binary distribution:
apache-solr-4.0-2011-11-03_08-39-12

The CharTokenizer.class file is here:
dist/apache-solr-4.0-2011-11-03_08-39-12.war/WEB-INF/lib/lucene-analyzers-common-4.0-2011-11-03_08-39-12.jar/org/apache/lucene/analysis/util/CharTokenizer.class

Is there any way to use Ant to build a plugin that uses CharTokenizer without first extracting the war file?

If not, could you consider having the lucene-analyzers-common-4.0-2011-11-03_08-39-12.jar file just in a directory in the binary distribution?
                
> factor CharTokenizer/CharacterUtils into analyzers module
> ---------------------------------------------------------
>
>                 Key: LUCENE-3063
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3063
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3063.patch
>
>
> Currently these analysis components are in the lucene core, but should really
> be .util in the analyzers module.
> Also, with MockTokenizer extending Tokenizer directly, we can add some additional
> checks in the future to try to ensure our consumers are being good consumers (e.g. calling reset).
> This is mentioned in http://wiki.apache.org/lucene-java/TestIdeas, I didn't implement it here yet,
> this is just the factoring. I think we should try to do this before LUCENE-3040.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3063) factor CharTokenizer/CharacterUtils into analyzers module

Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143544#comment-13143544 ] 

Steven Rowe commented on LUCENE-3063:
-------------------------------------

Hi Neil, 

You can download a Lucene nightly build as a binary tarball at [https://builds.apache.org/job/Lucene-trunk/lastSuccessfulBuild/artifact/artifacts/].

Alternatively, the individual nightly jars are available in Maven repository format here: [https://builds.apache.org/job/Lucene-Solr-Maven-trunk/lastSuccessfulBuild/artifact/maven_artifacts/org/apache/].  For example, the lucene analyzers common jar is here: [https://builds.apache.org/job/Lucene-Solr-Maven-trunk/lastSuccessfulBuild/artifact/maven_artifacts/org/apache/lucene/lucene-analyzers-common/4.0-SNAPSHOT/].  Note that this is a separate build, so the time stamps, and the time stamp format, will be different.
                
> factor CharTokenizer/CharacterUtils into analyzers module
> ---------------------------------------------------------
>
>                 Key: LUCENE-3063
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3063
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3063.patch
>
>
> Currently these analysis components are in the lucene core, but should really
> be .util in the analyzers module.
> Also, with MockTokenizer extending Tokenizer directly, we can add some additional
> checks in the future to try to ensure our consumers are being good consumers (e.g. calling reset).
> This is mentioned in http://wiki.apache.org/lucene-java/TestIdeas, I didn't implement it here yet,
> this is just the factoring. I think we should try to do this before LUCENE-3040.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-3063) factor CharTokenizer/CharacterUtils into analyzers module

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-3063.
---------------------------------

    Resolution: Fixed

Committed revision 1098871.

If there are any problems with hudson i'll yank it... for now I'll open a followup issue to add the additional checks to MockTokenizer

> factor CharTokenizer/CharacterUtils into analyzers module
> ---------------------------------------------------------
>
>                 Key: LUCENE-3063
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3063
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3063.patch
>
>
> Currently these analysis components are in the lucene core, but should really
> be .util in the analyzers module.
> Also, with MockTokenizer extending Tokenizer directly, we can add some additional
> checks in the future to try to ensure our consumers are being good consumers (e.g. calling reset).
> This is mentioned in http://wiki.apache.org/lucene-java/TestIdeas, I didn't implement it here yet,
> this is just the factoring. I think we should try to do this before LUCENE-3040.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org