[GitHub] [solr] dsmiley commented on pull request #1729: BackupRepository permit

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on PR #1729:
URL: https://github.com/apache/solr/pull/1729#issuecomment-1609850426

   @psalagnac LMK what you think.
   
   I briefly toyed with a FilterDirectory wrapper but then realized that the mechanism needn't implement anything; we just want a Semaphore.  Also I was unhappy with the DirectoryFactory relationship with Directory... I couldn't simply delegate close because the API is rather custom.  Could be improved.  If we wanted to rate limit, this could be explored more.
   
   I briefly toyed with BackupRepository constructor & close having this mechanism.  But I don't see that we actually close BackupRespository ?!  Also there are simple use-cases like listing backups and deleting and other things that are not heavy and don't want to hold a permit.
   
   A colleague named Gilles expressed concern that a "restore" should not wait in line like a backup; it's relatively rare and done in emergencies.  I think this is a good point, but I'd still want a similar mechanism described here to limit it somehow.  Maybe we have separate permit calls (backup vs restore).  And maybe a simple default implementation in which we track that restores are in progress.  If a backup gets a permit but sees restores in progress, it gives it up immediately, waits, and then tries again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org