You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2023/01/10 08:03:02 UTC

[GitHub] [hudi] danny0405 commented on a diff in pull request #7633: Fix Deletes issued without any prior commits

danny0405 commented on code in PR #7633:
URL: https://github.com/apache/hudi/pull/7633#discussion_r1065442435


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1637,8 +1637,6 @@ protected void setWriteSchemaForDeletes(HoodieTableMetaClient metaClient) {
         } else {
           throw new HoodieIOException("Latest commit does not have any schema in commit metadata");
         }
-      } else {
-        throw new HoodieIOException("Deletes issued without any prior commits");
       }

Review Comment:
   Shouldn't we throw exception if there is no dataset to delete ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org