You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/01 13:53:25 UTC

[GitHub] [spark] sarutak commented on a change in pull request #31412: [SPARK-34308][SQL] Escape meta-characters in printSchema

sarutak commented on a change in pull request #31412:
URL: https://github.com/apache/spark/pull/31412#discussion_r567840793



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/util/SchemaUtils.scala
##########
@@ -271,4 +271,18 @@ private[spark] object SchemaUtils {
     }
     field._1
   }
+
+  /**
+   * @param str The string to be escaped.
+   * @return The escaped string.
+   */
+  def escapeMetaCharacters(str: String): String = {

Review comment:
       Hmm, I intended to use this for escaping strings in schema so I implemented this in `SchemaUtils`.
   In fact, it's used for such purpose for now.
   If we find it's useful for other purposes, how about moving this into a different place in the future?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org