[GitHub] [zookeeper] jhuan31 commented on a change in pull request #1211: ZOOKEEPER-3683: Discard requests that are delayed longer than a confi…

[GitBox <gi...@apache.org>]

jhuan31 commented on a change in pull request #1211: ZOOKEEPER-3683: Discard requests that are delayed longer than a confi…
URL: https://github.com/apache/zookeeper/pull/1211#discussion_r397387285
 
 

 ##########
 File path: zookeeper-client/zookeeper-client-c/include/zookeeper.h
 ##########
 @@ -136,7 +136,8 @@ enum ZOO_ERRORS {
   ZEPHEMERALONLOCALSESSION = -120, /*!< Attempt to create ephemeral node on a local session */
   ZNOWATCHER = -121, /*!< The watcher couldn't be found */
   ZRECONFIGDISABLED = -123, /*!< Attempts to perform a reconfiguration operation when reconfiguration feature is disabled */
-  ZSESSIONCLOSEDREQUIRESASLAUTH = -124 /*!< The session has been closed by server because server requires client to do SASL authentication, but client is not configured with SASL authentication or configuted with SASL but failed (i.e. wrong credential used.). */
+  ZSESSIONCLOSEDREQUIRESASLAUTH = -124, /*!< The session has been closed by server because server requires client to do SASL authentication, but client is not configured with SASL authentication or configuted with SASL but failed (i.e. wrong credential used.). */
+  ZTHROTTLEDOP = -127 /*!< Operation was throttled and not executed at all. please, retry! */
 
 Review comment:
   We usually upstream a feature after it is deployed and if the number is taken when we upstream it, it's quite some trouble especially the number is used on the client side too. So we usually leave some holes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services