You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/05/12 13:08:58 UTC
[GitHub] [maven-toolchains-plugin] Syquel opened a new pull request #7: [WIP] Add new goal add-toolchain for adding new toolchains dynamically
Syquel opened a new pull request #7:
URL: https://github.com/apache/maven-toolchains-plugin/pull/7
This is a Work-In-Progress to gather some feedback.
Integration tests will be added.
Currently Maven toolchains must be configured manually or in other ways.
Especially in ad-hoc build environments like GitHub Actions this requires developers to write Shell scripts or other logic in the pipeline to create the toolchain.xml .
By providing this goal developers would be enabled to execute tests with multiple JDKs without having to run the build multiple times (or as a matrix build) in such ad-hoc build environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-toolchains-plugin] linux-china commented on pull request #7: [WIP] Add new goal add-toolchain for adding new toolchains dynamically
Posted by GitBox <gi...@apache.org>.
linux-china commented on pull request #7:
URL: https://github.com/apache/maven-toolchains-plugin/pull/7#issuecomment-947179929
How about auto download JDK from https://adoptium.net/ ? It's will be very useful for local development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-toolchains-plugin] linux-china edited a comment on pull request #7: [WIP] Add new goal add-toolchain for adding new toolchains dynamically
Posted by GitBox <gi...@apache.org>.
linux-china edited a comment on pull request #7:
URL: https://github.com/apache/maven-toolchains-plugin/pull/7#issuecomment-947179929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-toolchains-plugin] rfscholte commented on pull request #7: [WIP] Add new goal add-toolchain for adding new toolchains dynamically
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #7:
URL: https://github.com/apache/maven-toolchains-plugin/pull/7#issuecomment-839925771
I think this is a very ambitious plan (probably too ambitious).
Keep in mind that order should be preserved, just like comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-toolchains-plugin] mthmulders commented on pull request #7: [WIP] Add new goal add-toolchain for adding new toolchains dynamically
Posted by GitBox <gi...@apache.org>.
mthmulders commented on pull request #7:
URL: https://github.com/apache/maven-toolchains-plugin/pull/7#issuecomment-839975195
If it's specifically for GitHub actions, please know that since Maven 3.6.2, Maven will replace environment variables in toolchains.xml. This allows you to setup a toolchains.xml using the environment variables that GitHub Actions give you. An example is [this workflow](https://github.com/B3Partners/kadaster-gds2/blob/b0cd5c392bc1f48dec11c83c828254a868264467/.github/workflows/maven.yml#L37).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-toolchains-plugin] linux-china edited a comment on pull request #7: [WIP] Add new goal add-toolchain for adding new toolchains dynamically
Posted by GitBox <gi...@apache.org>.
linux-china edited a comment on pull request #7:
URL: https://github.com/apache/maven-toolchains-plugin/pull/7#issuecomment-947179929
How about download JDK from https://adoptium.net/ automatically? It's will be very useful for local development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-toolchains-plugin] linux-china edited a comment on pull request #7: [WIP] Add new goal add-toolchain for adding new toolchains dynamically
Posted by GitBox <gi...@apache.org>.
linux-china edited a comment on pull request #7:
URL: https://github.com/apache/maven-toolchains-plugin/pull/7#issuecomment-947179929
How about download JDK from https://adoptium.net/ or https://api.foojay.io/swagger-ui automatically? It's will be very useful for local development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-toolchains-plugin] linux-china edited a comment on pull request #7: [WIP] Add new goal add-toolchain for adding new toolchains dynamically
Posted by GitBox <gi...@apache.org>.
linux-china edited a comment on pull request #7:
URL: https://github.com/apache/maven-toolchains-plugin/pull/7#issuecomment-947179929
How about download JDK from https://adoptium.net/ or https://github.com/foojayio/discoapi automatically? It's will be very useful for local development.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org