You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ambari.apache.org by "Yusaku Sako (JIRA)" <ji...@apache.org> on 2017/04/27 19:11:04 UTC
[jira] [Created] (AMBARI-20878) Running "mvn package" on ambari-web
should not update the yarn.lock file
Yusaku Sako created AMBARI-20878:
------------------------------------
Summary: Running "mvn package" on ambari-web should not update the yarn.lock file
Key: AMBARI-20878
URL: https://issues.apache.org/jira/browse/AMBARI-20878
Project: Ambari
Issue Type: Bug
Components: ambari-web
Affects Versions: 2.5.1
Reporter: Yusaku Sako
Assignee: Yusaku Sako
Priority: Critical
Fix For: 2.5.1
Currently, when "mvn package" is run, yarn package manager *in some cases* updates the yarn.lock file. In theory, yarn.lock file should not change unless package.json is changed. However, it seems that this behavior is not guaranteed in some cases. This is a pain since yarn.lock is checked into git so whenever yarn.lock is updated, it is treated as uncommitted changes.
In Yarn package manager, there's an option called "--pure-lockfile" that prevents unexpected behavior from happening (there are some long discussions about why this behavior is not by default in the first place: https://github.com/yarnpkg/yarn/issues/570).
For mvn based builds, we can simply use that option.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)