You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2021/10/18 19:50:52 UTC
[GitHub] [maven-gh-actions-shared] slawekjaranowski opened a new pull request #9: Move common flags from maven_args to steps command
slawekjaranowski opened a new pull request #9:
URL: https://github.com/apache/maven-gh-actions-shared/pull/9
This change allow simpler use with other project than maven, which require different profileseg, we can
```yml
uses: apache/maven-gh-actions-shared/....
with:
maven_args: '-Pdocs'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-gh-actions-shared] olamy commented on pull request #9: Move common flags from maven_args to steps command
Posted by GitBox <gi...@apache.org>.
olamy commented on pull request #9:
URL: https://github.com/apache/maven-gh-actions-shared/pull/9#issuecomment-946302066
@khmarbaise this change really ensure using `--errors --batch-mode --show-version` for every build. still -1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-gh-actions-shared] olamy merged pull request #9: Move common flags from maven_args to steps command
Posted by GitBox <gi...@apache.org>.
olamy merged pull request #9:
URL: https://github.com/apache/maven-gh-actions-shared/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-gh-actions-shared] khmarbaise commented on pull request #9: Move common flags from maven_args to steps command
Posted by GitBox <gi...@apache.org>.
khmarbaise commented on pull request #9:
URL: https://github.com/apache/maven-gh-actions-shared/pull/9#issuecomment-946132510
From my point of view this repo contains gh actions for Apache Maven projects...so I would not remove `--errors` nor `--batch-mode` etc. so I'm -1 for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #9: Move common flags from maven_args to steps command
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #9:
URL: https://github.com/apache/maven-gh-actions-shared/pull/9#issuecomment-946142677
I don't remove it only move ... command will be call as:
```
mvn --errors --batch-mode --show-version ${{ inputs.maven_args }} verify
```
where default for `inputs.maven_args` is: `-P run-its -D"invoker.streamLogsOnFailures"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-gh-actions-shared] khmarbaise commented on pull request #9: Move common flags from maven_args to steps command
Posted by GitBox <gi...@apache.org>.
khmarbaise commented on pull request #9:
URL: https://github.com/apache/maven-gh-actions-shared/pull/9#issuecomment-946549200
> @khmarbaise this change really ensure using `--errors --batch-mode --show-version` for every build. still -1?
Then I'm fine with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org